Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Skip by default flexible tests when not enough nodes found #3173

Merged
merged 3 commits into from
May 8, 2024

Conversation

vkarak
Copy link
Contributor

@vkarak vkarak commented Apr 26, 2024

Flexible tests are now by default skipped when not enough nodes are found. We introduce a new option, --flex-alloc-strict that will cause the test to fail instead (the current default).

Closes #3164.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.67%. Comparing base (9607459) to head (6f6aba0).
Report is 12 commits behind head on develop.

❗ Current head 6f6aba0 differs from pull request most recent head 074f39f. Consider uploading reports for the commit 074f39f to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3173   +/-   ##
========================================
  Coverage    86.67%   86.67%           
========================================
  Files           61       61           
  Lines        12139    12143    +4     
========================================
+ Hits         10521    10525    +4     
  Misses        1618     1618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/manpage.rst Outdated Show resolved Hide resolved
@vkarak vkarak merged commit 5688d9c into reframe-hpc:develop May 8, 2024
23 checks passed
@vkarak vkarak deleted the feat/flex-nodes-skip branch May 8, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow for skipping a flexible test if not enough nodes are available instead of failing
2 participants