Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quic: always use empty session ID #297

Merged
merged 1 commit into from
May 3, 2024

Conversation

gaukas
Copy link
Member

@gaukas gaukas commented May 3, 2024

by RFC 9000 Section 8.4, QUIC must not send non-empty (legacy) session ID, otherwise server will return error.

  • It is also weird that so far we see no error from server due to uquic sending 32-byte session ID.

by RFC 9000 Section 8.4, QUIC must not send non-empty (legacy) session ID, otherwise server will return error.

* It is also weird that so far we see no error from server due to uquic sending 32-byte session ID.

Signed-off-by: Gaukas Wang <i@gaukas.wang>
@gaukas gaukas added the bug Unexpected behavior confirmed and should be fixed label May 3, 2024
@gaukas gaukas requested a review from sippejw May 3, 2024 02:34
@gaukas gaukas self-assigned this May 3, 2024
Copy link
Member

@sippejw sippejw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for fixing this @gaukas!

@gaukas gaukas merged commit 4f71339 into master May 3, 2024
6 checks passed
@gaukas gaukas deleted the fix-quic-must-use-empty-session-id branch May 3, 2024 14:39
gaukas added a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Unexpected behavior confirmed and should be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants