Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvments #53

Merged
merged 25 commits into from
Oct 12, 2021
Merged

Documentation improvments #53

merged 25 commits into from
Oct 12, 2021

Conversation

arm61
Copy link
Contributor

@arm61 arm61 commented Oct 7, 2021

Made a lot of improvements to the documentation. I have tried my best to be concise and documented both public facing API and internals.

@arm61 arm61 requested review from andyfaff and aglavic October 7, 2021 11:27
Makefile Show resolved Hide resolved
orsopy/fileio/base.py Show resolved Hide resolved
orsopy/fileio/base.py Show resolved Hide resolved
orsopy/fileio/base.py Outdated Show resolved Hide resolved
orsopy/fileio/data_source.py Show resolved Hide resolved
orsopy/fileio/data_source.py Outdated Show resolved Hide resolved
orsopy/fileio/data_source.py Show resolved Hide resolved
orsopy/fileio/data_source.py Outdated Show resolved Hide resolved
orsopy/fileio/reduction.py Outdated Show resolved Hide resolved
tests/test_fileio/test_data_source.py Show resolved Hide resolved
@arm61
Copy link
Contributor Author

arm61 commented Oct 8, 2021

I think we should look at getting #44 before we merge this, then I can rebase to main and improve documentation on anything new.

@arm61
Copy link
Contributor Author

arm61 commented Oct 8, 2021

Following a discussion with @aglavic yesterday, I have added coverage reporting via coveralls.

@arm61
Copy link
Contributor Author

arm61 commented Oct 11, 2021

@bmaranville @aglavic @jochenstahn @maxskoda any other comments on this PR?

@arm61 arm61 merged commit e979b0c into reflectivity:main Oct 12, 2021
@arm61 arm61 deleted the documentation_improvments branch January 7, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants