pin jsonschema to 3.2.0 #50
Conversation
| @@ -11,5 +11,5 @@ numpy>=1.19.0 | |||
|
|
|||
| pytest==6.2.4 | |||
| pyyaml>=5.4.1 | |||
| jsonschema | |||
| jsonschema==3.2.0 | |||
There was a problem hiding this comment.
Would have been better as <4?
There was a problem hiding this comment.
How are you testing (how did you find out it was breaking?)
EDIT: I think I found it... I was in a branch and didn't realize it.
There was a problem hiding this comment.
This seems to be two things: in jsonschema==4.0.1 they added two new validators (latest is default, which ends up being jsonschema.validators.Draft202012Validator). Our schema doesn't seem to be valid in that latest hyperschema.
Also, the Draft201909Validator in the package seems to be broken.
For the moment the most appropriate fix is probably to add
"$schema": "http://json-schema.org/draft-07/schema#" to the top of our schema. This will allow it to work with jsonschema==4.0.1 and we should be versioning the hyperschema anyway.
I will put in a PR shortly - have to go to a meeting right now.
There was a problem hiding this comment.
There was a problem hiding this comment.
In the newest draft 2020-12 "items" functionality is largely replaced by "prefixItems", and "additionalItems" is replaced by "items" ("additionalItems" goes away). That is why our schema doesn't load in the latest validator.
jsonschema released a 4.0.1 update that appears to break the schema testing. I have pinned to 3.2.0 (the previous release) until we can investigate further.