Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytest.yml #129

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update pytest.yml #129

wants to merge 2 commits into from

Conversation

arm61
Copy link
Contributor

@arm61 arm61 commented Apr 12, 2024

Remove the coveralls part of the Github action.

@arm61 arm61 requested a review from bmaranville April 12, 2024 11:36
@aglavic
Copy link
Collaborator

aglavic commented Apr 12, 2024

We could use coverage.py to run something similar as a github action. There is an output as html with detailed information that one might add to the docs, too.

I found this in a quick search: https://nedbatchelder.com/blog/202209/making_a_coverage_badge.html

@bmaranville
Copy link
Contributor

I tested the coverage.py solution you suggested here: https://bmaranville.github.io/orsopy/coverage/
It only takes a little bit of extra code in the action that builds the docs (builds the coverage document first), and we could of course add a link to the coverage report on the front page of the documentation.

I'm worried that the badge solution in that link is a little flimsy (storing state in a gist, requiring secrets, etc) and might require a lot more maintenance than the HTML output directly by coverage.py.

@arm61
Copy link
Contributor Author

arm61 commented May 16, 2024

@bmaranville and @aglavic do we want to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants