WIP: Feature/mobility #6

gloubier · 2018-05-09T12:47:00Z

Use Mobility instead of Globalize
Update to work with Refinery 4.0
Update to work with Rails 5
Add ability to disable slide and sliders

houndci-bot · 2018-05-09T12:47:18Z

config/routes.rb

@@ -16,4 +16,4 @@
    end
  end

-end
+end


Layout/TrailingBlankLines: Final newline missing.

houndci-bot · 2018-05-09T12:47:19Z

config/routes.rb

@@ -1,4 +1,4 @@
-Refinery::Core::Engine.routes.append do
+Refinery::Core::Engine.routes.draw do


Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-05-09T12:47:19Z

app/controllers/refinery/image_slideshows/admin/image_slides_controller.rb

-        before_filter :find_image_slide, :except => [:index, :new]
+        before_action :find_image_slideshow
+        before_action :find_image_slides, only: :index
+        before_action :find_image_slide, :except => [:index, :new]


Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
Style/SymbolArray: Use %i or %I for an array of symbols.

houndci-bot · 2018-05-09T12:47:19Z

Gemfile

  gem "refinerycms"

  group :test do
    gem "refinerycms-testing"
  end
 end

+# TODO: remove refinerycms-i18n and mobility from this Gemfile before merging this PR
+gem 'refinerycms-i18n', git: "https://github.com/refinery/refinerycms-i18n", branch: 'feature/mobility'


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Metrics/LineLength: Line is too long. [103/80]

houndci-bot · 2018-05-09T12:47:19Z

Gemfile

  gem "refinerycms"

  group :test do
    gem "refinerycms-testing"
  end
 end

+# TODO: remove refinerycms-i18n and mobility from this Gemfile before merging this PR


Metrics/LineLength: Line is too long. [85/80]

houndci-bot · 2018-05-09T12:47:20Z

db/migrate/7_create_image_slides_translations.rb

+class CreateImageSlidesTranslations < ActiveRecord::Migration[5.1]
+  def change
+    create_table :refinery_image_slide_translations do |t|
+


Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.

houndci-bot · 2018-05-09T12:47:21Z

db/migrate/7_create_image_slides_translations.rb

-      :migrate_data => true
-    })
-  end
+class CreateImageSlidesTranslations < ActiveRecord::Migration[5.1]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-05-09T12:47:21Z

db/migrate/6_add_height_and_width_to_image_slideshows.rb

@@ -1,4 +1,4 @@
-class AddHeightAndWidthToImageSlideshows < ActiveRecord::Migration
+class AddHeightAndWidthToImageSlideshows < ActiveRecord::Migration[5.1]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-05-09T12:47:21Z

db/migrate/5_add_link_url_to_image_slides.rb

@@ -1,4 +1,4 @@
-class AddLinkUrlToImageSlides < ActiveRecord::Migration
+class AddLinkUrlToImageSlides < ActiveRecord::Migration[5.1]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

houndci-bot · 2018-05-09T12:47:21Z

db/migrate/4_add_js_config_to_image_slideshows.rb

@@ -1,4 +1,4 @@
-class AddJsConfigToImageSlideshows < ActiveRecord::Migration
+class AddJsConfigToImageSlideshows < ActiveRecord::Migration[5.1]


Style/Documentation: Missing top-level class documentation comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.

Remove deprecated "quiet_assets" gem

Bugfix dependency resolution

bricesanchez · 2018-05-09T18:39:31Z

app/controllers/refinery/image_slideshows/admin/image_slideshows_controller.rb

@@ -9,6 +9,7 @@ class ImageSlideshowsController < ::Refinery::AdminController

          def image_slideshow_params
            params.require(:image_slideshow).permit(
+              :active,


by convention we use draft logic instead of active logic

bricesanchez · 2018-05-09T18:41:25Z

app/views/refinery/image_slideshows/admin/image_slides/_image_slide.html.erb

@@ -23,6 +24,10 @@
    <% end %>
  </span>

+  <%= content_tag :span, class: "#{image_slide.active? ? :success_icon : :failure_icon} less-important" do %>


We have label to handle draft display: https://github.com/refinery/refinerycms/blob/88f3eee61914d548dce5e7c1d1f8d3a57a0c9ece/pages/app/helpers/refinery/admin/pages_helper.rb#L51-L53

QA Feature/mobility

gloubier added 7 commits May 8, 2018 15:56

Change Gemfile and gemspec to use Mobility instead of Globalize

ded7082

Fix migrations

d2b8b0d

Fix routes

8fcf4e5

Change before_filter => before_action

3636a47

Update models to use mobility + modern syntax

4e6e0a2

Use Mobility.locale instead of Globalize.locale

97dd843

Fix action icons

e7c8a40

houndci-bot reviewed May 9, 2018

View reviewed changes

gloubier and others added 6 commits May 9, 2018 08:57

Fix Hound syntax comments

05f7475

Clean up Gemfile

01bd144

Remove deprecated "quiet_assets" gem

Update refinerycms-testing dependency version to 4.0.0

2f819f8

Update bin/rails to fix rails console start

bae7bce

Merge pull request #1 from refinerycms-contrib/feature/mobility

8dd9b65

Bugfix dependency resolution

Add active state to slideshows and slides

4caf0e9

bricesanchez requested changes May 9, 2018

View reviewed changes

gloubier and others added 11 commits May 9, 2018 15:30

Change active state to draft to follow conventions

b1b4599

Add live? method to easily check if is published

c48e2b1

Remove finder methods

107cddf

Delete script/rails

42edd2c

Now require refinerycms-images

4eb2a83

Remove height, width and js_config fields

7feb3fa

QA

1829e4d

Update README

9e7879a

Merge pull request #2 from refinerycms-contrib/feature/mobility

9d188d3

QA Feature/mobility

Remove unecessary stuff

20bc9a0

Add order field to slides relation

242ec70

bricesanchez self-requested a review February 26, 2020 22:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Feature/mobility #6

WIP: Feature/mobility #6

gloubier commented May 9, 2018 •

edited

houndci-bot May 9, 2018

houndci-bot May 9, 2018

houndci-bot May 9, 2018

houndci-bot May 9, 2018

houndci-bot May 9, 2018

houndci-bot May 9, 2018

houndci-bot May 9, 2018

houndci-bot May 9, 2018

houndci-bot May 9, 2018

houndci-bot May 9, 2018

bricesanchez May 9, 2018

bricesanchez May 9, 2018

@@ @@ -16,4 +16,4 @@ @@
                   end
                 end
-              end
+              end

		@@ -1,4 +1,4 @@
		Refinery::Core::Engine.routes.append do
		Refinery::Core::Engine.routes.draw do

		@@ -1,4 +1,4 @@
		class AddHeightAndWidthToImageSlideshows < ActiveRecord::Migration
		class AddHeightAndWidthToImageSlideshows < ActiveRecord::Migration[5.1]

		@@ -1,4 +1,4 @@
		class AddLinkUrlToImageSlides < ActiveRecord::Migration
		class AddLinkUrlToImageSlides < ActiveRecord::Migration[5.1]

		@@ -1,4 +1,4 @@
		class AddJsConfigToImageSlideshows < ActiveRecord::Migration
		class AddJsConfigToImageSlideshows < ActiveRecord::Migration[5.1]

WIP: Feature/mobility #6

Are you sure you want to change the base?

WIP: Feature/mobility #6

Conversation

gloubier commented May 9, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gloubier commented May 9, 2018 •

edited