Use octicons-plain-react
#7161
Merged
Use octicons-plain-react
#7161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZaLiTHkA
reviewed
May 9, 2024
There was a problem hiding this comment.
I'm having trouble getting this project running in my local dev environment, with "TS2307: Cannot find module" errors for all the octicons-plain-react imports.. @fregante, would this be a repo or dev env issue?
There was a problem hiding this comment.
Are you using the right Node and npm version? I think it should be node 20 now. The install works on CI so it's definitely not a repo issue
There was a problem hiding this comment.
just tested with NodeJS 20.13.1, built the project without any issues. sorry I didn't think to try that first, definitely not a repo issue then. thank you. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
octiconclasses attached primer/octicons#997@primer/octicons-reactusage, update/replace dependency #6878It doesn't look like Octicons is updated that often so it's best not to be blocked by them. It also has a few annoyances that we can just fix in our repo instead.
This has the nice benefit of moving the SVG->React transformation and complexity away from our build.
Screenshot
The new SVGs have the
classbefore thexmlnsattribute due tohttps://github.com/fregante/octicons-plain-react/blob/13b7daf92581954247ee68a292f83edffae7b680/scripts/prepack.sh#L11