Show more than three Avatars for Reactions #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ cool, finally I can use Infinity!
|
Also fixes this bug (selector was broken and was hiding more avatars than necessary):
|
That’s like a 30x size decrease!
fregante
force-pushed
the
all-the-musketeers
branch
from
26eed66
to
668a720
Compare
|
Loading 460x460 images bothered me, so thanks to this we load 40x40 or 20x20 images: https://stackoverflow.com/a/36380674/288906 |
|
Looks good. Another issue to test it with: facebook/react#10191 |
|
Excellent testbed. I already found a line that wraps:
Also this thread on hover facebook/react#8854
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #240
Testable on babel/babel#3646
Still limited and compressed when they don't fit:
Since this is now in JS, limited avatars won't be loaded at all (contrary to what happened before)