New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #3973
Update dependencies #3973
Conversation
Note that it's not done and that I'm personally skeptical about it. Destructuring can be nice, but sometimes it makes things less readable. I think it's hard to automate when it makes sense. |
I agree. I went through each one of the auto fixes to make sure that it makes sense. |
@fregante any of them should be reverted? |
I agree with Sindre, this PR is ok for the event listeners, but not the others. |
Let's take this opportunity to add https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines |
Weird, my commit didn’t change any code nor lint config |
Node 15 enables some features |
I think most of them are not applicable and used to be eslint-ignored before |
|
Too bad that size-plugin isn't fully maintained. It feels like we always have issues with it, and it's not like we need it to do much. Apparently there isn't any alternative and its output is basically perfect, so we just have to suck it up. |
Co-authored-by: Federico <me@fregante.com>
🎉 |
Please merge before something else has to be updated 😆 |
It's all yours |
Lint is Thanks to sindresorhus/eslint-plugin-unicorn#1045
I mainly did it to update the bugs octoicon to look like all the other new icons.
I was unable to update
size-plugin
I could not figure out why webpack stopped working.