Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #3973

Merged
merged 15 commits into from Feb 16, 2021
Merged

Update dependencies #3973

merged 15 commits into from Feb 16, 2021

Conversation

yakov116
Copy link
Member

Lint is Thanks to sindresorhus/eslint-plugin-unicorn#1045

I mainly did it to update the bugs octoicon to look like all the other new icons.

I was unable to update size-plugin I could not figure out why webpack stopped working.

@sindresorhus
Copy link
Member

Lint is Thanks to sindresorhus/eslint-plugin-unicorn#1045

Note that it's not done and that I'm personally skeptical about it. Destructuring can be nice, but sometimes it makes things less readable. I think it's hard to automate when it makes sense.

@yakov116
Copy link
Member Author

Note that it's not done and that I'm personally skeptical about it. Destructuring can be nice, but sometimes it makes things less readable. I think it's hard to automate when it makes sense.

I agree.

I went through each one of the auto fixes to make sure that it makes sense.

@yakov116
Copy link
Member Author

@fregante any of them should be reverted?

@fregante
Copy link
Member

fregante commented Feb 14, 2021

I agree with Sindre, this PR is ok for the event listeners, but not the others.

@fregante
Copy link
Member

Let's take this opportunity to add engines.npm >= 7

https://docs.npmjs.com/cli/v7/configuring-npm/package-json#engines

@yakov116 yakov116 added the meta Related to Refined GitHub itself label Feb 15, 2021
@yakov116 yakov116 marked this pull request as ready for review February 15, 2021 00:12
@fregante
Copy link
Member

fregante commented Feb 15, 2021

@fregante fregante self-assigned this Feb 15, 2021
@fregante fregante removed their assignment Feb 15, 2021
@fregante
Copy link
Member

Weird, my commit didn’t change any code nor lint config

@yakov116
Copy link
Member Author

Weird, my commit didn’t change any code nor lint config

Node 15 enables some features

@fregante
Copy link
Member

I think most of them are not applicable and used to be eslint-ignored before

webpack.config.ts Outdated Show resolved Hide resolved
@yakov116
Copy link
Member Author

I was unable to update size-plugin I could not figure out why webpack stopped working.

GoogleChromeLabs/size-plugin#40

@fregante
Copy link
Member

I was unable to update size-plugin I could not figure out why webpack stopped working.

GoogleChromeLabs/size-plugin#40

Too bad that size-plugin isn't fully maintained. It feels like we always have issues with it, and it's not like we need it to do much. Apparently there isn't any alternative and its output is basically perfect, so we just have to suck it up.

fregante and others added 2 commits February 15, 2021 22:26
@fregante
Copy link
Member

🎉

@yakov116
Copy link
Member Author

Please merge before something else has to be updated 😆

@fregante
Copy link
Member

It's all yours

@yakov116 yakov116 merged commit 7312381 into main Feb 16, 2021
@yakov116 yakov116 deleted the update_dep branch February 16, 2021 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Related to Refined GitHub itself
Development

Successfully merging this pull request may close these issues.

None yet

3 participants