Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate fast-reviews links #3209

Merged
merged 1 commit into from Jun 10, 2020

Conversation

yakov116
Copy link
Member

@yakov116 yakov116 commented Jun 9, 2020

image

I think the picture does all the explaining

chalk/chalk#392 really any pr

Press the conversation tab a few times, to get even more review nows :)

@fregante fregante added the bug label Jun 9, 2020
@fregante
Copy link
Member

This just happened on this very PR with the code on master. Can you also take care of it in this PR?

This is the resulting DOM:

<summary class="text-bold discussion-sidebar-heading discussion-sidebar-toggle hx_rsm-trigger" aria-haspopup="menu" data-hotkey="q" role="button">
      {icon}<span style="font-weight: normal;"><a href="https://github.com/sindresorhus/refined-github/pull/3209/files#submit-review" class="btn-link muted-link" data-hotkey="v">review now</a></span>
      Reviewers
</summary>

@fregante
Copy link
Member

Can you also take care of it in this PR?

Maybe not. The code looks correct. If it happens really often, it might need to be updated to use flex, but this might open up new bugs

summary {display: flex}
.octicon {order: 2; margin-left: auto}
.reviewnow {order: 1; margin-left: 0.3em}

@fregante fregante changed the title Only run fast-reviews once Avoid duplicate fast-reviews links Jun 10, 2020
@fregante fregante merged commit 5e01536 into refined-github:master Jun 10, 2020
@yakov116 yakov116 deleted the review-it-once branch June 10, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants