Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve GitHub Actions workflow files #2778

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Improve GitHub Actions workflow files #2778

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/no-banned-git-tags.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ jobs:
delete:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: fregante/setup-git-token@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
- run: git push --delete origin $GITHUB_REF
- uses: actions/checkout@v2
- uses: fregante/setup-git-token@v1
with:
token: ${{ secrets.GITHUB_TOKEN }}
Comment on lines +22 to +24
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you prefer these three lines or:

    - run: git config user.name "GitHub Actions" && git config user.email "actions@users.noreply.github.com"

Soft deprecation: https://github.com/fregante/setup-git-token

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer your action until actions/checkout#13 is resolved.

- run: git push --delete origin $GITHUB_REF
36 changes: 18 additions & 18 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,33 +7,33 @@ jobs:
Security:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- run: npx lockfile-lint --path package-lock.json --validate-https
- uses: actions/checkout@v2
- run: npx lockfile-lint --path package-lock.json --validate-https

AVA:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/setup-node@v1
with:
node-version: 11.x
- run: npm ci
- run: npx ava --serial
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
with:
node-version: 11.x
- run: npm ci
- run: npx ava --serial

Lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- run: npm ci
- run: npm run lint
- uses: actions/checkout@v2
- run: npm ci
- run: npm run lint

Build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- run: npm ci
- run: npm run build
- uses: actions/upload-artifact@v1
with:
name: refined-github
path: distribution
- uses: actions/checkout@v2
- run: npm ci
- run: npm run build
- uses: actions/upload-artifact@v1
with:
name: refined-github
path: distribution