Update dependencies and lint /2 #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
force-pushed
the
dependencies
branch
from
511ea1b
to
b269666
Compare
fregante
commented
Sep 16, 2019
| @@ -117,6 +117,7 @@ | |||
| "rules": { | |||
| "@typescript-eslint/no-misused-promises": "off", | |||
| "@typescript-eslint/promise-function-async": "off", | |||
| "@typescript-eslint/no-explicit-any": "error", | |||
There was a problem hiding this comment.
- It was disabled upstream xojs/eslint-config-xo-typescript@bbbf889
- But here its support was fixed: Stricter usage of
any#2429
| "import/no-unresolved": "warn", | ||
| "import/named": "warn" | ||
| "import/no-unresolved": "off", | ||
| "import/named": "off" |
There was a problem hiding this comment.
Reportedly disabled upstream: xojs/xo@ee145cb
...but it appears to still be enabled here, so I'm disabling it manually.
| "source" | ||
| "source", | ||
| "test", | ||
| "webpack.config.ts" |
There was a problem hiding this comment.
This fixed the issue I was having in the previous PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to solve the issues I had in #2391, so this updates the remaining linting dependencies to their latest version.