Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement rkyv endianess #136

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Implement rkyv endianess #136

merged 1 commit into from
Aug 18, 2023

Conversation

MucTepDayH16
Copy link
Contributor

I've notice, that you are using NotNan<T>/OrderedFloat<T> as Archived values. This leads to compilation failure if rkyv used with archive_le or archive_be features:

cargo t -F rkyv/archive_le
error[E0308]: mismatched types
    --> src/lib.rs:2013:46
     |
2013 |         let deser_float: OrderedFloat<f64> = archived_value.deserialize(&mut deserializer).unwrap();
     |                          -----------------   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `OrderedFloat<f64>`, found `With<_, _>`
     |                          |
     |                          expected due to this
     |
     = note: expected struct `OrderedFloat<f64>`
                found struct `With<_, _>`

My PR implements rkyv::Archive properly considering this features

Signed-off-by: MucTepDayH16 <denisdrozhzhin1999@gmail.com>
Copy link
Collaborator

@mbrubeck mbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mbrubeck mbrubeck merged commit 2b9f190 into reem:master Aug 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants