Pow support #132
Merged
Pow support #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! It looks like these just need to be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #118 asked for implementation of the Pow trait for OrderedFloat and NotNan. I have implemented the Pow trait for both in 2 ways.
I have not implemented any mixing of OrderedFloat and NotNan, as the proper return type is not obvious. I have also not implemented Pow for the base being primitive (i8, i16, i32, u8, u16, f32, f64) with an exponent of either OrderedFloat or NotNan, as again the return type for this operation is not clear to me.
I also added a few tests to ensure things are working as expected.