Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I forgot to actually test
cargo check --features rkyv_64
. It does not work becauserkyv_64 = ["dep:rkyv", "rkyv/size_64"]
treatsrkyv
in"rkyv/size_64"
as feature instead of dependency and"dep:rkyv/size_64"
is invalid. The fix is to avoid namespaced features when we have to enable a dependency of a dependency. I've triedrkyv_64 = ["dep:rkyv", "rkyv?/size_64"]
as well and it first seems to work but as soon asordered-float
is used in another crate it breaks.