Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix split of rkyv feature. #126

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Fix split of rkyv feature. #126

merged 1 commit into from
Apr 2, 2023

Conversation

n3vu0r
Copy link
Contributor

@n3vu0r n3vu0r commented Apr 2, 2023

Sorry, I forgot to actually test cargo check --features rkyv_64. It does not work because rkyv_64 = ["dep:rkyv", "rkyv/size_64"] treats rkyv in "rkyv/size_64" as feature instead of dependency and "dep:rkyv/size_64" is invalid. The fix is to avoid namespaced features when we have to enable a dependency of a dependency. I've tried rkyv_64 = ["dep:rkyv", "rkyv?/size_64"] as well and it first seems to work but as soon as ordered-float is used in another crate it breaks.

@mbrubeck mbrubeck merged commit f64ec17 into reem:master Apr 2, 2023
2 checks passed
@mbrubeck
Copy link
Collaborator

mbrubeck commented Apr 2, 2023

rkyv_64 = ["dep:rkyv", "rkyv?/size_64"] seems to work correctly for me. What sort of failures are you seeing?

My test crate has:

[dependencies]
ordered-float = { path = "../rust-ordered-float/", features = ["rkyv_64"] }
rkyv = { version = "*", default-features = false, features = ["size_64"] }

@n3vu0r
Copy link
Contributor Author

n3vu0r commented Apr 2, 2023

I tried again and indeed, no errors. Must have screwed up the cfg macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants