Add Storybook template for i18n #4764

simoncrypta · 2022-03-15T18:17:26Z

This will add the possibility to read the translation string and also change the language in Storybook !

Need @storybook/addon-essentials which I think should be included by default in RedwoodJS. I will open another PR to discuss ~~this really soon~~ #4765.

I copy the task configure-storybook from ui folder to i18n, I don't know if we should make this a lib accessible for all setup.

simoncrypta · 2022-03-15T21:01:09Z

@Tobbe You can probably be interesting at this one

packages/cli/src/commands/setup/i18n/tasks/configure-storybook.js

packages/cli/src/commands/setup/i18n/templates/i18n.js.template

packages/cli/src/commands/setup/i18n/templates/storybook.preview.js.template

Tobbe · 2022-03-18T20:38:26Z

How can we make this compatible with also adding Chakra support? Support for merging SB configs instead of overwriting.

thedavidprice · 2022-03-18T21:34:21Z

Thanks for moving this forward @simoncrypta and @Tobbe 🚀

@virtuoushub and @shilman Could I get your high-level review about this PR as well as #3515

Recently, Yann gave Pete and I some guidance that we should move away from currenlty having a StorybookProvider decorator and instead looking into loaders. I'm not sure if that direction has any overlap with how Simon is approaching i18n support here. So just making sure to close any potential communication gaps most of all!

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

netlify · 2022-03-20T18:04:40Z

✅ Deploy Preview for redwoodjs-docs canceled.

Name	Link
🔨 Latest commit	`e1b353a`
🔍 Latest deploy log	https://app.netlify.com/sites/redwoodjs-docs/deploys/6243fd8ae8b5e40008533124

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

simoncrypta · 2022-03-20T18:12:01Z

@Tobbe I will look a way to not overwrite if the file is already create !
@thedavidprice I was looking loaders and I don't think this can be use for i18n plugin, I will try to dig more about this.

simoncrypta · 2022-03-22T23:33:29Z

How can we make this compatible with also adding Chakra support? Support for merging SB configs instead of overwriting.

I duplicate the configure-storybook file of Chakra to make it work with i18n, but I will prefer to have only one. Since we need to merge SB config with whatever that come first, using the same configure-storybook script make sense, but where did I put this file ? If it at /setup/tasks/configure-storybook.js do I need to write something to exclude it for yargs ?

Tobbe · 2022-03-24T00:22:47Z

but where did I put this file ? If it at /setup/tasks/configure-storybook.js do I need to write something to exclude it for yargs ?

I don't know. I think you just have to try it and see what happens :)

simoncrypta · 2022-03-24T01:03:10Z

Let's Go !

thedavidprice · 2022-03-24T18:43:56Z

Nice work, everyone!

I really want to make sure @virtuoushub reviews and approves the Storybook config additions here. Looping him in.

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

simoncrypta · 2022-03-29T18:28:36Z

@Tobbe Thanks again for your great reviews!
For #4953 Nothing to do for this
But for #4900, depend on who merge first, we just need to consider the new configureStorybook lib.

Tobbe · 2022-03-29T18:31:36Z

packages/cli/src/lib/configureStorybook.js

+
+      const insideNewStorybookConfigWithoutReactAndDecoration =
+        newStorybookPreview
+          .replace(/import *. as React from 'react'/, '')


Suggested change

.replace(/import *. as React from 'react'/, '')

.replace(/import *. as React from 'react'/, '')

Sorry I didn't see this earlier. Did you mean to make that .* (instead of *.)?

I test the regex, I think is right, but I will double-check

Yeah, it matches "space" zero or more times, then "any character", then "space", etc. So it works. I just wasn't sure if that's what you were going for :)

You probably want /import \* as React from 'react'/

Oh! yeah right, I had tried this and didn't work, but I'm not the best at regex, so I will test again.

https://regexr.com/6if2h

simoncrypta · 2022-03-29T18:34:00Z

@Tobbe, I wonder if this new lib overlaps on the rewrite of configureStorybook ?
setup-component-library.js
TBH, I like how it solved the problem, so no hard feeling if we use the other one as base. Just need to merge it first.

packages/cli/src/commands/setup/ui/templates/storybook.preview.js.template

Tobbe · 2022-03-29T18:43:38Z

TBH, I like how it solved the problem, so no hard feeling if we use the other one as base. Just the to merge it first.

@simoncrypta I agree, it's nicely done. But I still think, if you just address my last couple of comments we can get this one in first, and then he can handle the merge conflicts and overwrite your changes with what he's got going on there.

packages/cli/src/commands/setup/i18n/i18n.js

packages/cli/src/commands/setup/i18n/templates/storybook.preview.js.template

Co-authored-by: Peter Colapietro <petercolapietro+github@gmail.com>

…nto fix/subdirectory-routing * 'fix/subdirectory-routing' of github.com:dac09/redwood: Clarify the cell aliasing section of tutorial (redwoodjs#4964) s/posts/articles (redwoodjs#4971) fix(deps): update dependency cross-undici-fetch to v0.1.28 (redwoodjs#4966) Add Storybook template for i18n (redwoodjs#4764) Add @storybook/addon-essentials by default (redwoodjs#4765)

simoncrypta added 4 commits March 15, 2022 13:35

clean and order .use(LanguageDetector)

08e9f26

add storybook template for i18n

1243f7e

add configure storybook to i18n CLI

8a890a0

add configure-storybook task to i18n

b7db6b4

simoncrypta added topic/cli release:feature This PR introduces a new feature labels Mar 15, 2022

simoncrypta requested a review from jtoar March 15, 2022 18:17

simoncrypta self-assigned this Mar 15, 2022

simoncrypta mentioned this pull request Mar 15, 2022

Add @storybook/addon-essentials by default #4765

Merged

simoncrypta added the topic/storybook label Mar 15, 2022

Merge branch 'main' into sg-i18n-storybook

61595df

simoncrypta and others added 2 commits March 15, 2022 18:18

Merge branch 'main' into sg-i18n-storybook

26625e2

Merge branch 'main' into sg-i18n-storybook

ab1c305

Tobbe reviewed Mar 18, 2022

View reviewed changes

Update comment

6174a25

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

simoncrypta and others added 2 commits March 20, 2022 14:05

Update storybook.preview.js.template

e2951fe

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Fix lint storybook.preview.js.template

695cd65

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Simon Gagnon and others added 3 commits March 22, 2022 10:55

Merge branch 'main' into sg-i18n-storybook

5e15bde

remove unused eslint-disable-next-line

268a0ce

Merge branch 'main' into sg-i18n-storybook

269f356

Merge branch 'main' into sg-i18n-storybook

71f7790

simoncrypta and others added 7 commits March 29, 2022 13:51

Update naming configureStorybook

92a397f

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Update naming

78bd63d

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Simplify code

95a38dd

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

update naming

b741e61

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Update naming

d4b074d

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Update naming

1d64c27

Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>

Merge branch 'main' into sg-i18n-storybook

1b12ff7

Merge branch 'main' into sg-i18n-storybook

18bb8b7

Tobbe reviewed Mar 29, 2022

View reviewed changes

packages/cli/src/commands/setup/ui/templates/storybook.preview.js.template Outdated Show resolved Hide resolved

Tobbe reviewed Mar 29, 2022

View reviewed changes

packages/cli/src/commands/setup/i18n/i18n.js Outdated Show resolved Hide resolved

Tobbe added 5 commits March 29, 2022 22:27

Update packages/cli/src/commands/setup/i18n/i18n.js

20db020

hoc naming

8c4c5e9

Merge branch 'main' into sg-i18n-storybook

f904d15

configureStorybook: Format code and tweak regex

f192fbe

storybook preview config: Add eslint comment

bea1975

virtuoushub reviewed Mar 29, 2022

View reviewed changes

packages/cli/src/commands/setup/i18n/templates/storybook.preview.js.template Show resolved Hide resolved

virtuoushub reviewed Mar 29, 2022

View reviewed changes

packages/cli/src/commands/setup/i18n/templates/storybook.preview.js.template Outdated Show resolved Hide resolved

Tobbe and others added 2 commits March 30, 2022 06:16

Apply suggestions from code review

9339169

Co-authored-by: Peter Colapietro <petercolapietro+github@gmail.com>

Merge branch 'main' into sg-i18n-storybook

e1b353a

Tobbe enabled auto-merge (squash) March 30, 2022 06:53

Tobbe merged commit dd9656b into redwoodjs:main Mar 30, 2022

jtoar added this to the next-release milestone Mar 30, 2022

Tobbe mentioned this pull request Mar 30, 2022

cli/lib/merge & setup ui mantine #4900

Merged

4 tasks

thedavidprice modified the milestones: next-release, v1.1.0 Apr 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Storybook template for i18n #4764

Add Storybook template for i18n #4764

simoncrypta commented Mar 15, 2022 •

edited

simoncrypta commented Mar 15, 2022

Tobbe commented Mar 18, 2022

thedavidprice commented Mar 18, 2022

netlify bot commented Mar 20, 2022 •

edited

simoncrypta commented Mar 20, 2022 •

edited

simoncrypta commented Mar 22, 2022

Tobbe commented Mar 24, 2022

simoncrypta commented Mar 24, 2022

thedavidprice commented Mar 24, 2022

simoncrypta commented Mar 29, 2022

Tobbe Mar 29, 2022

simoncrypta Mar 29, 2022

Tobbe Mar 29, 2022

Tobbe Mar 29, 2022

simoncrypta Mar 29, 2022

Tobbe Mar 29, 2022

simoncrypta commented Mar 29, 2022 •

edited

Tobbe commented Mar 29, 2022

	.replace(/import *. as React from 'react'/, '')
	.replace(/import *. as React from 'react'/, '')

Add Storybook template for i18n #4764

Add Storybook template for i18n #4764

Conversation

simoncrypta commented Mar 15, 2022 • edited

simoncrypta commented Mar 15, 2022

Tobbe commented Mar 18, 2022

thedavidprice commented Mar 18, 2022

netlify bot commented Mar 20, 2022 • edited

✅ Deploy Preview for redwoodjs-docs canceled.

simoncrypta commented Mar 20, 2022 • edited

simoncrypta commented Mar 22, 2022

Tobbe commented Mar 24, 2022

simoncrypta commented Mar 24, 2022

thedavidprice commented Mar 24, 2022

simoncrypta commented Mar 29, 2022

Tobbe Mar 29, 2022

Choose a reason for hiding this comment

simoncrypta Mar 29, 2022

Choose a reason for hiding this comment

Tobbe Mar 29, 2022

Choose a reason for hiding this comment

Tobbe Mar 29, 2022

Choose a reason for hiding this comment

simoncrypta Mar 29, 2022

Choose a reason for hiding this comment

Tobbe Mar 29, 2022

Choose a reason for hiding this comment

simoncrypta commented Mar 29, 2022 • edited

Tobbe commented Mar 29, 2022

simoncrypta commented Mar 15, 2022 •

edited

netlify bot commented Mar 20, 2022 •

edited

simoncrypta commented Mar 20, 2022 •

edited

simoncrypta commented Mar 29, 2022 •

edited