Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Storybook build args #4455

Merged
merged 12 commits into from
Feb 18, 2022
Merged

Fix Storybook build args #4455

Changes from 2 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f2b3a8a
open arg default set to false
josemasar Feb 12, 2022
5fea0c5
small indentation correction
josemasar Feb 13, 2022
1b6e09f
separate logic for 3 cases
josemasar Feb 15, 2022
6743acf
small fix: param deleted in build
josemasar Feb 15, 2022
d609a75
PR comments resolved
josemasar Feb 16, 2022
0a6dc3c
fixing quote marks
josemasar Feb 16, 2022
f1c81c5
Merge branch 'main' into jmsar-storybook-build-fails-default-open-arg
thedavidprice Feb 16, 2022
6f534c2
no open argument included
josemasar Feb 17, 2022
1f4dfb8
Merge branch 'jmsar-storybook-build-fails-default-open-arg' of https:…
josemasar Feb 17, 2022
6e8d375
Merge branch 'main' into jmsar-storybook-build-fails-default-open-arg
thedavidprice Feb 17, 2022
375e70a
Merge branch 'main' into pr/4455
thedavidprice Feb 18, 2022
5683992
Merge branch 'main' into jmsar-storybook-build-fails-default-open-arg
thedavidprice Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/cli/src/commands/storybook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export const builder = (yargs) => {
.option('open', {
describe: 'Open storybooks in your browser on start',
type: 'boolean',
default: true,
default: false,
})
.option('build', {
describe: 'Build Storybook',
Expand Down Expand Up @@ -85,7 +85,6 @@ export const handler = ({
!build && '--no-version-updates',
!managerCache && '--no-manager-cache',
build && `--output-dir "${buildDirectory}"`,
!open && !smokeTest && `--ci`,
smokeTest && `--ci --smoke-test`,
].filter(Boolean),
{
Expand Down