New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storybook ci option to test that Storybook starts "ok" #3515
Merged
thedavidprice
merged 14 commits into
redwoodjs:main
from
virtuoushub:chore/add-storybook-ci-option-to-test-start-storybook-ok
Jan 24, 2022
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
83b0452
add rw storybook --ci option passing --smoke-test
thedavidprice daec4ea
fix: do not stub `process.env`
virtuoushub ef20e2b
chore: enable typechecking
virtuoushub 8be9491
refactor(rename): ci -> smoke-test
virtuoushub 8afd1c8
chore: add some logic checks
virtuoushub f899152
feat: wire up smoke test
virtuoushub c04a676
fix: run checker in synchronously mode
virtuoushub d060185
chore: shorten timeout and fail faster
virtuoushub 683745a
chore: try and move this into a before
virtuoushub a17b8e0
use sb --smoke-test for E2E; remove Cypress spec
thedavidprice e71dd9d
fix: only set up type checking for typescript projects
thedavidprice 1d42a01
Merge branch 'main' into chore/add-storybook-ci-option-to-test-start-…
thedavidprice c7a6b85
Merge branch 'main' into chore/add-storybook-ci-option-to-test-start-…
thedavidprice 6014b79
Update tasks/e2e/cypress/integration/03-storybook/storybook.spec.js
thedavidprice File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @virtuoushub, me again! We have a small regression caused by this change here. Wondering if you could give me a little more context to what this change was for/why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without this, the Storbook --ci and --smoke-test flags were failing. (Please correct me if I am wrong.)
FYI, Pete, Danny is going to remove Dotenv entirely over here #4334 Based on all the research you did, any reaction as to whether this removal will have downstream affect on Storybook config? (We are assuming none.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dac09 , it was added to avoid:
See also: #3515 (comment)
@thedavidprice , I think the removal should be safe; 🤞🏻 that the smoke test catches a regression if I am wrong.