Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update css loader and setup tailwind #2611

Closed
wants to merge 2 commits into from
Closed

Update css loader and setup tailwind #2611

wants to merge 2 commits into from

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented May 23, 2021

This PR updates css-loader to accommodate postcss 8 and updates the tailwind setup command accordingly.

@jtoar jtoar self-assigned this May 23, 2021
@jtoar jtoar added this to In progress in Current-Release-Sprint via automation May 23, 2021
@jtoar jtoar added this to the next-release-candidate milestone May 23, 2021
@jtoar jtoar added topic/config Babel, Webpack, ESLint, Prettier, etc. v1-priority labels May 23, 2021
peterp
peterp approved these changes May 23, 2021
View reviewed changes
Copy link
Contributor

@peterp peterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! We should keep an eye on Tailwind's JIT mode for the generated configuration! https://tailwindcss.com/docs/just-in-time-mode

@thedavidprice
Copy link
Contributor

Per conversation with @jtoar this seems dependent on first upgrading to Webpack v5 in #2402

@jtoar jtoar moved this from In progress to In progress (priority) in Current-Release-Sprint Jun 4, 2021
@thedavidprice thedavidprice removed this from the next-release-priority milestone Jun 9, 2021
@thedavidprice thedavidprice moved this from In progress (priority) to Backlog PRs in Current-Release-Sprint Jun 9, 2021
@jtoar jtoar added this to the next-release-priority milestone Jun 10, 2021
@thedavidprice
Copy link
Contributor

now included in #2884

@redwoodjs-bot redwoodjs-bot bot removed this from the next-release-priority milestone Jul 15, 2021
@redwoodjs-bot redwoodjs-bot bot removed this from Backlog PRs in Current-Release-Sprint Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterp peterp peterp approved these changes

Assignees

@jtoar jtoar

Labels
topic/config Babel, Webpack, ESLint, Prettier, etc. topic/fully-integrated-dx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtoar @thedavidprice @peterp @redwoodjsbot