Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update travis Node.js version & remove io.js #698

Merged
merged 2 commits into from Sep 11, 2015
Merged

Update travis Node.js version & remove io.js #698

merged 2 commits into from Sep 11, 2015

Conversation

desenmeng
Copy link
Contributor

No description provided.

@timdorr
Copy link
Member

timdorr commented Sep 9, 2015

Looks like there are issues with contextify. Unfortunately, @brianmcd hasn't update the project in a while and it's not been working with iojs 3.0 either. Anyone know of any alternatives?

@gaearon
Copy link
Contributor

gaearon commented Sep 9, 2015

We can wait for Lodash 4 (#611) and then we won't need that test relying on contextify.

@timdorr
Copy link
Member

timdorr commented Sep 10, 2015

@demohi Can you merge in master to your branch? It should now run correctly under 4.0.0. I've tested locally and want to double-check against Travis.

@desenmeng
Copy link
Contributor Author

@timdorr I merged that.

@timdorr
Copy link
Member

timdorr commented Sep 11, 2015

Looks like there's an upstream fix in webpack-dev-server (and socket.io) that isn't been released yet. It should fix all those npm build errors in Travis. But it runs, so it's good for now.

timdorr added a commit that referenced this pull request Sep 11, 2015
Update travis Node.js version & remove io.js
@timdorr timdorr merged commit 90f6d83 into reduxjs:master Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants