Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ActionTypes to a private export #1343

Closed
wants to merge 1 commit into from
Closed

Conversation

timdorr
Copy link
Member

@timdorr timdorr commented Feb 1, 2016

For the first action item of #1342.

@mxstbr
Copy link
Contributor

mxstbr commented Mar 3, 2016

Pretty sure we can merge this, see #1342 (comment)

@gaearon
Copy link
Contributor

gaearon commented Mar 6, 2016

Yes, but I’d like to merge all breaking changes to master at the same time before cutting a release. It is weird when breaking changes linger in master. I’m fine with starting a 4.x branch where we do that though.

@timdorr
Copy link
Member Author

timdorr commented Mar 6, 2016

We have a next branch on router.

@gaearon
Copy link
Contributor

gaearon commented Mar 6, 2016

Sounds reasonable 👍

@timdorr
Copy link
Member Author

timdorr commented Mar 6, 2016

If you want, I can create a next branch and reopen this against that branch.

@gaearon
Copy link
Contributor

gaearon commented Mar 6, 2016

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants