Don't include standard utilities in redux #1225
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the minified bundle by only ~100 bytes, but means that people can re-use these same utilities in their application and save some space, and squeeze a bit of extra peformance out of JS engines by having fewer implementations of the same thing.
I'd also be happy to add you @gaearon to the organization/npm account if you want control over the things redux depends on.
Whether or not you use my specific deps, it seems like a good idea to externalize the common utilities, since almost every project needs a
pick/compose/map-values/is-object
anyway.