Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include standard utilities in redux #1225

Closed
wants to merge 1 commit into from

Conversation

ashaffer
Copy link
Contributor

This increases the minified bundle by only ~100 bytes, but means that people can re-use these same utilities in their application and save some space, and squeeze a bit of extra peformance out of JS engines by having fewer implementations of the same thing.

I'd also be happy to add you @gaearon to the organization/npm account if you want control over the things redux depends on.

Whether or not you use my specific deps, it seems like a good idea to externalize the common utilities, since almost every project needs a pick/compose/map-values/is-object anyway.

@gaearon
Copy link
Contributor

gaearon commented Jan 10, 2016

Hey, thanks.
We plan to use Lodash 4 for this: #611.

but means that people can re-use these same utilities in their application and save some space, and squeeze a bit of extra peformance out of JS engines by having fewer implementations of the same thing.

It's very unrealistic to expect people to use these same libraries since they are very new. Relying on something already popular like Lodash seems like a better idea. If we want to shift support burden (which isn't a lot to be honest for these utilities), we should switch it to something more popular than Redux—not less.

Thanks for PR though!

@gaearon gaearon closed this Jan 10, 2016
@ashaffer
Copy link
Contributor Author

Ya, that makes sense. FYI it looks like lodash 4 just got released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants