Merge pull request #4383 from raulsanchez1024/enable-prefer-type-only…

…-imports

Enable prefer type-only imports

.eslintrc.cjs

@@ -31,6 +31,10 @@ module.exports = {
         argsIgnorePattern: '^_',
         varsIgnorePattern: '^_'
       }
-    ]
+    ],
+    '@typescript-eslint/consistent-type-imports': [
+      'error',
+      { prefer: 'type-imports', disallowTypeAnnotations: false },
+    ],
   }
 }

src/applyMiddleware.ts

@@ -1,6 +1,6 @@
 import compose from './compose'
-import { Middleware, MiddlewareAPI } from './types/middleware'
-import { StoreEnhancer, Dispatch } from './types/store'
+import type { Middleware, MiddlewareAPI } from './types/middleware'
+import type { StoreEnhancer, Dispatch } from './types/store'
 
 /**
  * Creates a store enhancer that applies middleware to the dispatch method

src/bindActionCreators.ts

@@ -1,5 +1,5 @@
-import { Dispatch } from './types/store'
-import { ActionCreator, ActionCreatorsMapObject, Action } from './types/actions'
+import type { Dispatch } from './types/store'
+import type { ActionCreator, ActionCreatorsMapObject, Action } from './types/actions'
 import { kindOf } from './utils/kindOf'
 
 function bindActionCreator<A extends Action>(

src/combineReducers.ts

@@ -1,5 +1,5 @@
-import { Action } from './types/actions'
-import {
+import type { Action } from './types/actions'
+import type {
   ActionFromReducersMapObject,
   PreloadedStateShapeFromReducersMapObject,
   Reducer,

src/createStore.ts

@@ -1,15 +1,15 @@
 import $$observable from './utils/symbol-observable'
 
-import {
+import type {
   Store,
   StoreEnhancer,
   Dispatch,
   Observer,
   ListenerCallback,
   UnknownIfNonSpecific
 } from './types/store'
-import { Action } from './types/actions'
-import { Reducer } from './types/reducers'
+import type { Action } from './types/actions'
+import type { Reducer } from './types/reducers'
 import ActionTypes from './utils/actionTypes'
 import isPlainObject from './utils/isPlainObject'
 import { kindOf } from './utils/kindOf'

src/types/middleware.ts

@@ -1,4 +1,4 @@
-import { Dispatch } from './store'
+import type { Dispatch } from './store'
 
 export interface MiddlewareAPI<D extends Dispatch = Dispatch, S = any> {
   dispatch: D

src/types/reducers.ts

@@ -1,4 +1,4 @@
-import { Action, UnknownAction } from './actions'
+import type { Action, UnknownAction } from './actions'
 
 /* reducers */
 

src/types/store.ts

@@ -1,5 +1,5 @@
-import { Action, UnknownAction } from './actions'
-import { Reducer } from './reducers'
+import type { Action, UnknownAction } from './actions'
+import type { Reducer } from './reducers'
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 import _$$observable from '../utils/symbol-observable'
 

test/applyMiddleware.spec.ts

@@ -1,12 +1,5 @@
-import {
-  createStore,
-  applyMiddleware,
-  Middleware,
-  MiddlewareAPI,
-  Action,
-  Store,
-  Dispatch
-} from 'redux'
+import { createStore, applyMiddleware } from 'redux'
+import type { Middleware, MiddlewareAPI, Action, Store, Dispatch } from 'redux'
 import { vi } from 'vitest'
 import * as reducers from './helpers/reducers'
 import { addTodo, addTodoAsync, addTodoIfEmpty } from './helpers/actionCreators'

test/bindActionCreators.spec.ts

@@ -1,4 +1,5 @@
-import { bindActionCreators, createStore, ActionCreator, Store } from '../src'
+import { bindActionCreators, createStore } from '../src'
+import { ActionCreator, Store } from '../src'
 import { todos } from './helpers/reducers'
 import * as actionCreators from './helpers/actionCreators'
 

test/combineReducers.spec.ts

@@ -1,9 +1,8 @@
 /* eslint-disable no-console */
+import type { Reducer, Action } from 'redux'
 import {
   createStore,
   combineReducers,
-  Reducer,
-  Action,
   __DO_NOT_USE__ActionTypes as ActionTypes
 } from 'redux'
 import { vi } from 'vitest'

test/createStore.spec.ts

@@ -1,11 +1,5 @@
-import {
-  createStore,
-  combineReducers,
-  StoreEnhancer,
-  Action,
-  Store,
-  Reducer
-} from 'redux'
+import type { StoreEnhancer, Action, Store, Reducer } from 'redux'
+import { createStore, combineReducers } from 'redux'
 import { vi } from 'vitest'
 import {
   addTodo,
@@ -17,7 +11,8 @@ import {
   unknownAction
 } from './helpers/actionCreators'
 import * as reducers from './helpers/reducers'
-import { from, ObservableInput } from 'rxjs'
+import type { ObservableInput } from 'rxjs'
+import { from } from 'rxjs'
 import { map } from 'rxjs/operators'
 import $$observable from '../src/utils/symbol-observable'
 

test/helpers/actionCreators.ts

@@ -7,8 +7,8 @@ import {
   THROW_ERROR,
   UNKNOWN_ACTION
 } from './actionTypes'
-import { TodoAction } from './reducers'
-import { Dispatch } from 'redux'
+import type { TodoAction } from './reducers'
+import type { Dispatch } from 'redux'
 
 export function addTodo(text: string): TodoAction {
   return { type: ADD_TODO, text }

test/helpers/middleware.ts

@@ -1,4 +1,4 @@
-import { Dispatch, Middleware } from 'redux'
+import type { Dispatch, Middleware } from 'redux'
 
 export const thunk: Middleware<{
   <R>(thunk: (dispatch: Dispatch, getState: () => any) => R): R

test/typescript/actionCreators.ts

@@ -1,10 +1,10 @@
-import {
+import type {
   ActionCreator,
   Action,
   Dispatch,
-  bindActionCreators,
   ActionCreatorsMapObject
 } from 'redux'
+import { bindActionCreators } from 'redux'
 
 interface AddTodoAction extends Action {
   text: string

test/typescript/actions.ts

@@ -1,4 +1,4 @@
-import { Action as ReduxAction } from 'redux'
+import type { Action as ReduxAction } from 'redux'
 
 namespace FSA {
   interface Action<P> extends ReduxAction {

test/typescript/dispatch.ts

@@ -1,4 +1,4 @@
-import { Dispatch } from 'redux'
+import type { Dispatch } from 'redux'
 
 /**
  * Default Dispatch type accepts any object with `type` property.

test/typescript/enhancers.ts

@@ -1,4 +1,5 @@
-import { StoreEnhancer, Action, Reducer, createStore } from 'redux'
+import type { StoreEnhancer, Action, Reducer } from 'redux'
+import { createStore } from 'redux'
 
 interface State {
   someField: 'string'

test/typescript/injectedDispatch.ts

@@ -1,4 +1,4 @@
-import { Dispatch, Action } from 'redux'
+import type { Dispatch, Action } from 'redux'
 
 interface Component<P> {
   props: P

test/typescript/middleware.ts

@@ -1,12 +1,11 @@
-import {
+import type {
   Middleware,
   MiddlewareAPI,
-  applyMiddleware,
-  createStore,
   Dispatch,
   Reducer,
   Action
 } from 'redux'
+import { applyMiddleware, createStore } from 'redux'
 
 /**
  * Logger middleware doesn't add any extra types to dispatch, just logs actions

test/typescript/reducers.ts

@@ -1,10 +1,5 @@
-import {
-  Reducer,
-  Action,
-  combineReducers,
-  ReducersMapObject,
-  AnyAction
-} from 'redux'
+import type { Reducer, Action, ReducersMapObject, AnyAction } from 'redux'
+import { combineReducers } from 'redux'
 
 /**
  * Simple reducer definition with no action shape checks.

test/typescript/store.ts

@@ -1,12 +1,11 @@
-import {
+import { combineReducers, createStore } from 'redux'
+import type {
   Store,
-  createStore,
   Reducer,
   Action,
   StoreEnhancer,
   Unsubscribe,
-  Observer,
-  combineReducers
+  Observer
 } from 'redux'
 import 'symbol-observable'