Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use main reactiflux invite" #855

Merged
merged 1 commit into from Dec 25, 2020
Merged

Revert "Use main reactiflux invite" #855

merged 1 commit into from Dec 25, 2020

Conversation

nickmccurdy
Copy link
Collaborator

Reverts #768

Follow up on reduxjs/react-redux#1673

@netlify
Copy link

netlify bot commented Dec 23, 2020

Deploy preview for redux-starter-kit-docs ready!

Built with commit 3d7b355

https://deploy-preview-855--redux-starter-kit-docs.netlify.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3d7b355:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration
rsk-github-issues-example Configuration

@github-actions
Copy link

Size Change: 0 B

Total Size: 69.3 kB

ℹ️ View Unchanged
Filename Size Change
dist/index.js 149 B 0 B
dist/redux-toolkit.cjs.development.js 13.8 kB 0 B
dist/redux-toolkit.cjs.production.min.js 5.25 kB 0 B
dist/redux-toolkit.esm.js 13.7 kB 0 B
dist/redux-toolkit.umd.js 25.6 kB 0 B
dist/redux-toolkit.umd.min.js 10.9 kB 0 B

compressed-size-action

@nickmccurdy
Copy link
Collaborator Author

CI is failing on the type test but I'm only modifying documentation

@phryneas
Copy link
Member

phryneas commented Dec 24, 2020

Yeah, it's only Travis. That shouldn't be here any more anyways.

On the topic itself though: would this channel-specific invite work? As far as I remember, when signing up for the server, all channels are locked and you have to check a checkbox over in announcements or so to gain access. Landing in another channel might be counterproductive?

@nickmccurdy
Copy link
Collaborator Author

nickmccurdy commented Dec 25, 2020

Would this channel-specific invite work? As far as I remember, when signing up for the server, all channels are locked and you have to check a checkbox over in announcements or so to gain access. Landing in another channel might be counterproductive?

Yes. We've made our community channels public as we're now using rule screening instead of private channels with the Reaction Role bot.

@phryneas
Copy link
Member

Ah, I missed that! Then let's get it in :)

@phryneas phryneas merged commit d0c21cd into master Dec 25, 2020
@nickmccurdy nickmccurdy deleted the revert-768-patch-1 branch December 26, 2020 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants