Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle bigint in useQuerySubscription #4315

Merged
merged 5 commits into from May 9, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 13 additions & 5 deletions packages/toolkit/src/query/defaultSerializeQueryArgs.ts
rkofman marked this conversation as resolved.
Show resolved Hide resolved
Expand Up @@ -9,6 +9,7 @@ const cache: WeakMap<any, string> | undefined = WeakMap
export const defaultSerializeQueryArgs: SerializeQueryArgs<any> = ({
endpointName,
queryArgs,
replacer,
}) => {
let serialized = ''

Expand All @@ -17,33 +18,40 @@ export const defaultSerializeQueryArgs: SerializeQueryArgs<any> = ({
if (typeof cached === 'string') {
serialized = cached
} else {
const stringified = JSON.stringify(queryArgs, (key, value) =>
isPlainObject(value)
const stringified = JSON.stringify(queryArgs, (key, value) => {
// Use custom replacer first before applying key-sorting behavior:
value = replacer ? replacer(key, value) : value
// Sort the object keys before stringifying, to prevent useQuery({ a: 1, b: 2 }) having a different cache key than useQuery({ b: 2, a: 1 })
value = isPlainObject(value)
? Object.keys(value)
.sort()
.reduce<any>((acc, key) => {
acc[key] = (value as any)[key]
return acc
}, {})
: value,
)
: value
return value
})
if (isPlainObject(queryArgs)) {
cache?.set(queryArgs, stringified)
}
serialized = stringified
}
// Sort the object keys before stringifying, to prevent useQuery({ a: 1, b: 2 }) having a different cache key than useQuery({ b: 2, a: 1 })
return `${endpointName}(${serialized})`
}

export type SerializeQueryArgs<QueryArgs, ReturnType = string> = (_: {
queryArgs: QueryArgs
endpointDefinition: EndpointDefinition<any, any, any, any>
endpointName: string
// Allows for a custom stringify replacer while keeping key-sorting behavior. e.g. for serializing bigint.
replacer?: (key: string, value: any) => {}
rkofman marked this conversation as resolved.
Show resolved Hide resolved
}) => ReturnType

export type InternalSerializeQueryArgs = (_: {
queryArgs: any
endpointDefinition: EndpointDefinition<any, any, any, any>
endpointName: string
// Allows for a custom stringify replacer while keeping key-sorting behavior. e.g. for serializing bigint.
replacer?: (key: string, value: any) => {}
}) => QueryCacheKey
5 changes: 4 additions & 1 deletion packages/toolkit/src/query/react/buildHooks.ts
Expand Up @@ -761,14 +761,17 @@ export function buildHooks<Definitions extends EndpointDefinitions>({
subscriptionSelectorsRef.current =
returnedValue as unknown as SubscriptionSelectors
}
const bigIntReplacer = (_: string, value: any) =>
typeof value === 'bigint' ? { $bigint: value.toString() } : value
const stableArg = useStableQueryArgs(
skip ? skipToken : arg,
// Even if the user provided a per-endpoint `serializeQueryArgs` with
// a consistent return value, _here_ we want to use the default behavior
// so we can tell if _anything_ actually changed. Otherwise, we can end up
// with a case where the query args did change but the serialization doesn't,
// and then we never try to initiate a refetch.
defaultSerializeQueryArgs,
(params) =>
defaultSerializeQueryArgs({ replacer: bigIntReplacer, ...params }),
context.endpointDefinitions[name],
name,
)
Expand Down
38 changes: 36 additions & 2 deletions packages/toolkit/src/query/tests/buildHooks.test.tsx
Expand Up @@ -100,7 +100,7 @@ const api = createApi({
getError: build.query({
query: () => '/error',
}),
listItems: build.query<Item[], { pageNumber: number }>({
listItems: build.query<Item[], { pageNumber: number | bigint }>({
serializeQueryArgs: ({ endpointName }) => {
return endpointName
},
Expand Down Expand Up @@ -151,6 +151,7 @@ beforeEach(() => {
})

afterEach(() => {
nextItemId = 0
amount = 0
listenerMiddleware.clearListeners()
})
Expand Down Expand Up @@ -630,7 +631,40 @@ describe('hooks tests', () => {
test(`useQuery refetches when query args object changes even if serialized args don't change`, async () => {
function ItemList() {
const [pageNumber, setPageNumber] = useState(0)
const { data = [] } = api.useListItemsQuery({ pageNumber })
const { data = [] } = api.useListItemsQuery({
pageNumber: pageNumber,
})

const renderedItems = data.map((item) => (
<li key={item.id}>ID: {item.id}</li>
))
return (
<div>
<button onClick={() => setPageNumber(pageNumber + 1)}>
Next Page
</button>
<ul>{renderedItems}</ul>
</div>
)
}

render(<ItemList />, { wrapper: storeRef.wrapper })

await screen.findByText('ID: 0')

await act(async () => {
screen.getByText('Next Page').click()
})

await screen.findByText('ID: 3')
})

test(`useQuery gracefully handles bigint types`, async () => {
function ItemList() {
const [pageNumber, setPageNumber] = useState(0)
const { data = [] } = api.useListItemsQuery({
pageNumber: BigInt(pageNumber),
})

const renderedItems = data.map((item) => (
<li key={item.id}>ID: {item.id}</li>
Expand Down