Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TypeScript to 5.4 #4255

Merged
merged 23 commits into from May 9, 2024
Merged

Update TypeScript to 5.4 #4255

merged 23 commits into from May 9, 2024

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Bumps TypeScript version for toolkit and the root package.json to 5.4.
  • Fixes TypeScript 5.4 issue related to calling dispatch inside createAsyncThunk.
  • Fixes TypeScript 5.4 issue related to builder.addCase in createReducer.test-d.ts type tests.
  • Adds TypeScript 5.4 to TypeScript versions to test against during CI.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Mar 6, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Mar 6, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6cfeb58:

Sandbox Source
rsk-github-issues-example Configuration
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@netlify Netlify
Copy link

netlify bot commented Mar 6, 2024 •
edited

✅ Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 6cfeb58
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/663c15c5d616e700083f3a56
😎 Deploy Preview https://deploy-preview-4255--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aryaemami59 aryaemami59 marked this pull request as ready for review March 6, 2024 19:45
aryaemami59 and others added 19 commits March 8, 2024 13:29
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
8edbe4f 
…o update-ts-to-5.4
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
7251a67 
…o update-ts-to-5.4
@EskiMojo14
require dispatch type to extend thunkdispatch
7f1ef6b
@aryaemami59
Fix dispatch type in AsyncThunkAction to be NonNullable
17bf9ed 
  - This was done so that the type tests for TypeScript v4.7 and v4.8 pass.
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
41ecb92 
…o update-ts-to-5.4
@aryaemami59
Bump TypeScript to 5.4.3
a376837
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
653ecad 
…o update-ts-to-5.4
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
e2b7c9c 
…o update-ts-to-5.4
@aryaemami59
Bump TypeScript version to 5.4.4
2a9461e
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
edbddd1 
…o update-ts-to-5.4
@aryaemami59
Bump TypeScript version to 5.4.5
d45f4e7
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
8a411d4 
…o update-ts-to-5.4
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
6e45a36 
…o update-ts-to-5.4
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
0c127e6 
…o update-ts-to-5.4
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
d2a5dee 
…o update-ts-to-5.4
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
9fa6c1e 
…o update-ts-to-5.4
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
c26e056 
…o update-ts-to-5.4
@aryaemami59
Merge branch 'update-ts-to-5.4' of https://github.com/aryaemami59/red…
cd7b335 
…ux-toolkit; branch 'master' of https://github.com/reduxjs/redux-toolkit into update-ts-to-5.4
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
6cfeb58 
…o update-ts-to-5.4
@markerikson markerikson merged commit 13ae28b into reduxjs:master May 9, 2024
28 checks passed
@aryaemami59 aryaemami59 deleted the update-ts-to-5.4 branch May 9, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EskiMojo14 EskiMojo14 EskiMojo14 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aryaemami59 @EskiMojo14 @markerikson