Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Centralize tooling configs in monorepo #4138

Open
wants to merge 343 commits into
base: master
Choose a base branch
from
Open

Centralize tooling configs in monorepo #4138

wants to merge 343 commits into from

Conversation

aryaemami59
Copy link
Contributor

This PR:

  • Creates dedicated repos housing shareable config files for ESLint, Prettier, TypeScript and Vitest.

@codesandbox CodeSandbox
Copy link

codesandbox bot commented Jan 29, 2024

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

@netlify Netlify
Copy link

netlify bot commented Jan 29, 2024 •
edited

✅ Deploy Preview for redux-starter-kit-docs ready!

Name Link
🔨 Latest commit 4a4a666
🔍 Latest deploy log https://app.netlify.com/sites/redux-starter-kit-docs/deploys/663c38cf518404000702b48b
😎 Deploy Preview https://deploy-preview-4138--redux-starter-kit-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jan 29, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a4a666:

Sandbox Source
@examples-query-react/basic Configuration
@examples-query-react/advanced Configuration
@examples-action-listener/counter Configuration
rtk-esm-cra Configuration

@EskiMojo14 EskiMojo14 mentioned this pull request Jan 31, 2024
Closed
@aryaemami59
Add missing import
20e28c9
@aryaemami59
Move custom matchers into vitest.setup.ts
0c85c57 
  - This was done so that we won't have to import `helpers.tsx` anywhere we use `toHaveConsoleOutput`
@aryaemami59 aryaemami59 marked this pull request as ready for review February 8, 2024 13:45
EskiMojo14
EskiMojo14 reviewed Feb 8, 2024
View reviewed changes
packages/toolkit/src/createAsyncThunk.ts Outdated Show resolved Hide resolved
packages/toolkit/src/combineSlices.ts Outdated Show resolved Hide resolved
packages/toolkit/src/entities/tests/state_selectors.test-d.ts Outdated Show resolved Hide resolved
packages/toolkit/src/tests/createSlice.test.ts Outdated Show resolved Hide resolved
@markerikson
Copy link
Collaborator

Okay, what I think I'm seeing here is:

  • Added the configs
  • A lot of lint fixes, mostly around auto-sorting of imports and forcing type imports
  • Extracting some reusable TS types like AnyObject

Can I get a summary of what lint rules changed?

Also it looks like there's some commented out lint rules in the ESLint config

@aryaemami59
Copy link
Contributor Author

@markerikson

Sure, so mostly what I did was, add 2 configs:

  • plugin:@typescript-eslint/recommended
  • plugin:@typescript-eslint/stylistic

Along with prettier which turns off ESLint rules that conflict with Prettier.
Then I fixed all the lint issues, and the ones that were not worth fixing (or were too time consuming) I disabled.
As for the commented out rules, I will probably put up another PR after this one, with those rules and configs enabled and make adjustments and fixes as needed. I just did not want to do it all in one PR because this PR is already way too large as it is.

@EskiMojo14
Copy link
Collaborator

could you add a "prepack": "yarn build" script to any of the packages with a build step? it means we can use our existing publish action with them

@aryaemami59
Copy link
Contributor Author

could you add a "prepack": "yarn build" script to any of the packages with a build step? it means we can use our existing publish action with them

Yeah sure!

@aryaemami59
Include files that start with a dot during type checking
ce6ac1e
@aryaemami59
Make peerDependencies of @reduxjs/eslint-config optional
170bbcb
@aryaemami59
Fix peerDependencies of @reduxjs/prettier-config
02f382d
@aryaemami59
Fix peerDependencies of @reduxjs/vitest-config
c2537b4
@aryaemami59
Fix peerDependencies of @reduxjs/tsconfig
ead7e1a
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
0b1887b 
…o configs
@aryaemami59
Bump typescript-eslint to 7.7.1 for @reduxjs/eslint-config
8f984bc
@aryaemami59
Bump @types/eslint to 8.56.10 for @reduxjs/eslint-config
88b194a
@aryaemami59
Bump @eslint/js to 9.1.1 for @reduxjs/eslint-config
a90630d
@aryaemami59
Bump eslint to 9.1.1 for @reduxjs/eslint-config
1b43a0f
@aryaemami59
Bump globals to version 15.1.0 for @reduxjs/eslint-config
96e6eb2
@aryaemami59
Bump vitest to version 1.5.2 for @reduxjs/vitest-config
68c6515
@aryaemami59
Bump vitest to version 1.5.2 for toolkit
c260be5
@aryaemami59
Move vitest from dependencies to peerDependencies
27718ee
@aryaemami59
Add onTestFailed and onTestFinished to vitestGlobals
248d027
@aryaemami59
Remove @typescript-eslint packages from toolkit
2346e2c 
  - This change was made because `@reduxjs/eslint-config` includes the `typescript-eslint` package as a direct dependency which includes `@typescript-eslint/eslint-plugin` and `@typescript-eslint/parser` as direct dependencies so there is no need to manually install them anymore.
@aryaemami59
Update @typescript-eslint packages to version 7.7.1
f2ea52a
@aryaemami59
Bump typescript-eslint to version 7.8.0 for @reduxjs/eslint-config
54eeacf
@aryaemami59
Update @typescript-eslint packages to version 7.8.0
7c79018
@aryaemami59
Make ESLint a required peer dependency of @reduxjs/eslint-config
0cc88c6
@aryaemami59
Bump vitest to version 1.5.3 for @reduxjs/vitest-config
63d7b31
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
03ebe78 
…o configs
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
3ea0e84 
…o configs
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
d366368 
…o configs
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
2a4935b 
…o configs
@aryaemami59
Bump vitest to 1.6.0 for @reduxjs/vitest-config
ff173f2
@aryaemami59
Bump ESLint for @reduxjs/eslint-config
c34149b
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
2e966ea 
…o configs
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
b624627 
…o configs
@aryaemami59
Merge branch 'master' of https://github.com/reduxjs/redux-toolkit int…
4a4a666 
…o configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EskiMojo14 EskiMojo14 EskiMojo14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aryaemami59 @markerikson @EskiMojo14