Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no-resolution flag and add --exclude-entrypoints when running are-the-types-wrong during CI #2155

Merged
merged 1 commit into from Apr 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/test.yml
Expand Up @@ -93,10 +93,8 @@ jobs:
path: .

# Note: We currently expect "FalseCJS" failures for Node16 + `moduleResolution: "node16",
# and the `/alternateRenderers" entry point will not resolve under Node10.
# Skipping these is dangerous, but we'll leave it for now.
- name: Run are-the-types-wrong
run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs no-resolution
run: npx @arethetypeswrong/cli ./package.tgz --format table --ignore-rules false-cjs --exclude-entrypoints alternate-renderers

test-published-artifact:
name: Test Published Artifact ${{ matrix.example }}
Expand Down