Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commands H*EXPIRE* and H*TTL to include constant FIELDS #13270

Merged
merged 9 commits into from
May 16, 2024
Merged

Fix commands H*EXPIRE* and H*TTL to include constant FIELDS #13270

merged 9 commits into from
May 16, 2024

Conversation

moticless
Copy link
Collaborator

@moticless moticless commented May 15, 2024 •
edited

Instead of HEXPIRE myhash 1 NX 1 field1
will be: HEXPIRE myhash 1 NX FIELDS 1 field1

The same goes to: HPEXPIRE, HEXPIREAT, HPEXPIREAT, HEXPIRETIME, HPEXPIRETIME, HPTTL, HTTL, HPERSIST

@moticless moticless changed the base branch from unstable to hash-field-expiry-integ May 15, 2024 11:04
@LiorKogan LiorKogan mentioned this pull request May 15, 2024
Merged
@moticless moticless requested a review from tezc May 15, 2024 13:01
tezc
tezc reviewed May 15, 2024
View reviewed changes
src/t_hash.c Outdated Show resolved Hide resolved
tezc
tezc previously approved these changes May 15, 2024
View reviewed changes
@dwdougherty
Copy link

dwdougherty commented May 15, 2024 •
edited

Apologies if I'm intruding here, but I don't see HPEXPIREAT in the list of changes. Maybe it's in another PR? Also, from the PRD, it looks like HPERSIST should also have the FIELDS argument.

@moticless
Copy link
Collaborator Author

@dwdougherty, I forgot to modify hpersist.json. Thanks!

LiorKogan
LiorKogan reviewed May 16, 2024
View reviewed changes
src/t_hash.c Outdated Show resolved Hide resolved
LiorKogan
LiorKogan reviewed May 16, 2024
View reviewed changes
src/t_hash.c Outdated Show resolved Hide resolved
@moticless moticless merged commit 7167651 into redis:hash-field-expiry-integ May 16, 2024
14 checks passed
@moticless moticless deleted the hfe-integ-fix-hexpire-cmd branch May 16, 2024 16:36
@tezc tezc mentioned this pull request May 18, 2024
Merged
tezc added a commit that referenced this pull request May 18, 2024
@tezc
Fix hfe RDB tests by adding FIELDS keyword to hexpire commands (#13277)
36c3cec 
FIELDS keyword was added as part of
[#13270](#13270). 

It was missing in
[#13243](#13243)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorKogan LiorKogan LiorKogan approved these changes

@tezc tezc tezc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@moticless @dwdougherty @LiorKogan @tezc