New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to silence exists
warning message.
#920
Conversation
I'm not too sure what that broken test is relating to. |
Looks good. Please squash your commits together and I'll merge. |
Looks like rubocop is unhappy. Some lines are too long. |
The warning message can be disabled by setting `exists_returns_integer` to `false`. You will receive a single warning message when this is set.
aa2a432
to
4d72b11
Compare
This was actually in relation to actual test failures in the pubsub ruby stuff, looked like duplicate things were in there. But yes, seems that commit made Rubocop unhappy for other reasons. Normally I'd set up a local dev environment but I'm just relying on CI for this :) |
Unfortunately we have a couple flaky tests in the suite. It's getting better but it's really hard to stabilize, lot's of moving parts with the distributed redis testing. |
Right I thought it might be something like that. I think anything complex has some flaky tests somewhere... |
Related to #698.
The warning message can be disabled by setting
exists_returns_integer
tofalse
. You will receive a single warning message when this is set.