Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XCLAIM exception on nil result #906

Closed
wants to merge 1 commit into from

Conversation

eadz
Copy link

@eadz eadz commented May 17, 2020

See issue #905

@byroot
Copy link
Collaborator

byroot commented May 17, 2020

In which circumstances? Could you add a unit test to show it and ensure it won't be broken again in the future?

@eadz
Copy link
Author

eadz commented May 17, 2020

@byroot Happy to add tests, but I was unable to see any tests that tests the lamdas, so a little unsure where to start. Are there any tests at all for those lamdas and/or respone processing from the streams stuff?

The issue #905 has the redis call that will trigger the error. You may need to create the stream and consumer group first, but then in that response you should get an array with [nil]. You can see how this will break the lamda as it tries to call each_slice on nil.

@eadz eadz changed the title Fix XCLAIM exeption on nil result Fix XCLAIM exception on nil result May 17, 2020
@eadz
Copy link
Author

eadz commented May 17, 2020

Ok, I'm having trouble reproducing this. I'll close for now, and re-open when I can reproduce.

@eadz eadz closed this May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants