Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TLS connections not verified by default #900

Merged
merged 1 commit into from May 1, 2020
Merged

Fix TLS connections not verified by default #900

merged 1 commit into from May 1, 2020

Commits on Apr 25, 2020

  1. Verify certs by default under TLS 

    `SSLContext#set_params` is the step in SSL connection establishment that
merges user-provided SSL parameters with "saner defaults".

Previously `SSLContext#set_params` was only being called when
`ssl_params` was provided to the SSLConnection, so the SSLContexet was
left unconfigured. This leads to the surprising default `verify_mode` of
`nil`, resulting in SSL connections verifying hostnames but never
verifying certificate trust.
    @bpo
    bpo committed Apr 25, 2020
    Copy the full SHA
    3dc3374 View commit details
    Browse the repository at this point in the history