Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md: Disable reconnecting which doubles the duration until unsubscribe #885

Merged
merged 1 commit into from Nov 17, 2020

Commits on Jan 19, 2020

  1. Disable reconnecting which doubles the duration until unsubscribe

    * Problem: In the "Timeouts" section in README, it says "If no message is
      received after 5 seconds, the client will unsubscribe." but it actually
      unsubscribes after 10 seconds. It's because by default reconnect_attempts is
      1 and the client tries subscribing for 5 seconds twice.
    * Solution: Explicitly set reconnect_attempts to 0
        * This can be tricky for first time readers since the "Reconnections"
          section comes after this "Timeouts" section.
        * Alternative solution: change the description that it will unsubscribe
          after 10 seconds.
    ujihisa committed Jan 19, 2020
    Copy the full SHA
    949d8ef View commit details
    Browse the repository at this point in the history