Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the :nearest_slave role for Sentinel mode #588

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add the :nearest_slave role for Sentinel mode #588

wants to merge 3 commits into from

Commits on Aug 17, 2020

  1. Add the :nearest_slave role for Sentinel mode 

    This will cause the client to measure roundtrip latency to each slave
and select the slave with the lowest latency. The intent for this is
to enable sentinel-managed clusters of servers for which eventually-consistent
reads are acceptable, but to maintain minimum latencies between any
individual client-slave pair.

The case I did this for is is shared web application caching across multiple
datacenters, where you would not want Redis to connect to a slave in another
datacenter, but you would want all datacenters to share a cache.

Remove trailing comma from client creation options; should fix 1.8 builds

If we can't get the role, use a translated role

Ensure that ping test clients are always disconnected after use. Don't assume that a good slave was found.
    @cheald
    cheald committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    3893355 View commit details
    Browse the repository at this point in the history

  2. Add the :nearest mode, which selects the closest node by ping, regard… 

    …less of role
    @cheald
    cheald committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    0e52d43 View commit details
    Browse the repository at this point in the history

  3. Style fixes to make Rubocop happy

    @cheald
    cheald committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    a49c23d View commit details
    Browse the repository at this point in the history