Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an empty array instead of throwing ArgumentError if the transaction is empty in the cluster client #1265

Merged
merged 1 commit into from Apr 17, 2024
Merged

Return an empty array instead of throwing ArgumentError if the transaction is empty in the cluster client #1265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions cluster/test/commands_on_transactions_test.rb
View file
Open in desktop
Expand Up @@ -24,9 +24,7 @@ def test_multi
redis.multi
end

assert_raises(ArgumentError) do
redis.multi {}
end
assert_empty(redis.multi {})

assert_equal([1], redis.multi { |r| r.incr('counter') })
end
Expand Down Expand Up @@ -56,6 +54,8 @@ def test_watch
end
end

assert_empty(redis.watch('{key}1', '{key}2') {})

redis.watch('{key}1', '{key}2') do |tx|
tx.call('SET', '{key}1', '1')
tx.call('SET', '{key}2', '2')
Expand Down