Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Rubocop against Ruby 3.2 #1245

Merged
merged 1 commit into from Jan 8, 2024

Conversation

KJTsanaktsidis
Copy link
Contributor

There's no reason to run Rubocop against such an old version of Ruby; it's perfectly capable of parsing code according to Ruby 2.6 rules even when running on a more modern ruby (TargetRubyVersion in rubocop.yml). So, just run it on Ruby 3.2.

There's no reason to run Rubocop against such an old version of Ruby;
it's perfectly capable of parsing code according to Ruby 2.6 rules even
when running on a more modern ruby (`TargetRubyVersion` in rubocop.yml).
So, just run it on Ruby 3.2.
@KJTsanaktsidis KJTsanaktsidis marked this pull request as ready for review January 8, 2024 21:47
@byroot byroot merged commit 09acb90 into redis:master Jan 8, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants