Handle unknown subclasses of RedisClient::Error in clustering #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Redis::Client code already knows how to crawl up through exception ancestors and match that against the hash; call into that code from Redis::Cluster::Client as well. Otherwise, you can get KeyError raised from e.g. pipeline blocks instead of the real error that happened.
|
I don't think I'm responsible for the rubygems problems or the truffleruby crash :/ so I think this should be OK to look at? 🤷 rubygems/rubygems#6197 - I wonder if we need to specify a desired version of rubygems to install explicitly if we want to keep running rubocop on 2.6 |
supercaracal
approved these changes
Jan 8, 2024
|
Yeah, we can figure out the rubocop issue later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Redis::Client code already knows how to crawl up through exception ancestors and match that against the hash; call into that code from Redis::Cluster::Client as well. `
Otherwise, you can get KeyError raised from e.g. pipeline blocks instead of the real error that happened.