Cluster: Preserve message and suberrors when raising CommandErrorCollection #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection The constructor signature for CommandErrorCollection is (errors, message). That means if you call "raise CommandErrorCollection, 'foobar'", that actually winds up setting the _errors_ field to 'foobar', _NOT_ the message. This leads to incredibly undescriptive "Command errors were replied on any node" errors getting emitted if there are errors using pipelining. Fix this by: 1) explicitly constructing the error, with the arguments in the right order 2) mapping the sub-errors into redis-rb errors too - presumably there's an :errors attr_reader because somebody will find that useful.
KJTsanaktsidis
force-pushed
the
ktsanaktsidis/make_error_collection_useful
branch
from
f639f1a
to
07e7849
Compare
|
I'll wait for @supercaracal 's opinion. |
supercaracal
approved these changes
Nov 17, 2023
|
Not late at all. Thank you for maintaining clustering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor signature for CommandErrorCollection is (errors, message). That means if you call "raise CommandErrorCollection, 'foobar'", that actually winds up setting the errors field to 'foobar', NOT the message. This leads to incredibly undescriptive "Command errors were replied on any node" errors getting emitted if there are errors using pipelining.
Fix this by: