Handle OpenSSL v3 EOF errors #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: redis#1106 When Ruby is compiled against OpenSSL V3, if an SSL connection is closed without sending a `close_notify`, a `OpenSSL::SSL::SSLError` will be raised.
This was referenced Jun 30, 2022
|
I deployed this branch to production using heroku-22 1.5 hours ago. No errors this time! 馃憤 馃帀 (Previously, with the released |
|
I ran into this problem on Heroku last week, and worked around it by setting the redis-side connection timeouts to 25 hours. Thanks a bunch for the fix! 馃榿 |
|
Been running 4.7.1 in production on heroku-22 and everything seems to be good now. 馃憤 |
|
Today we are faced with OpenSSL::SSL::SSLError SSL_read: unexpected eof while readingOur current Redis Gem version is "4.8.1". But Heroku version is heroku-22. What could be the reason for this error? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1106
When Ruby is compiled against OpenSSL V3, if an SSL connection is closed without sending a
close_notify, aOpenSSL::SSL::SSLErrorwill be raised.I tested this manually, it works s expected. Unfortunately we don't have SSL setup on CI, and it's a big pain to do (I did it for
redis-client), so I'm tempted to ship with just a manual test, or maybe just a mock? 馃槥