Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Redis 6.2] Add GEOSEARCH command #1080

Closed
wants to merge 1 commit into from
Closed

Conversation

uxgnod
Copy link

@uxgnod uxgnod commented Feb 24, 2022

Add support for GEOSEARCH command, which is available since 6.2.0.

@byroot
Copy link
Collaborator

byroot commented Feb 24, 2022

The CI failure is legit, you have a syntax error.

As for the API, I'm not a fan of these keyword being used for two different things based on the passed type, it seems brittle to me.

I think I'd prefer:

def geosearch(key, from_member: nil, from_lonlat, by_radius: nil, by_box: nil, **options)
end

@uxgnod
Copy link
Author

uxgnod commented Feb 24, 2022

The CI failure is legit, you have a syntax error.

As for the API, I'm not a fan of these keyword being used for two different things based on the passed type, it seems brittle to me.

I think I'd prefer:

def geosearch(key, from_member: nil, from_lonlat, by_radius: nil, by_box: nil, **options)
end

Thanks for the advice, I really don't have much experience and I will try to fix these errors.

Also, can you please tell me how I should test this code locally?

@byroot
Copy link
Collaborator

byroot commented Feb 24, 2022

Also, can you please tell me how I should test this code locally?

You can run make then make test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants