Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to silence exists warning message. #920

Merged
merged 1 commit into from Jun 11, 2020

Conversation

simonrussell
Copy link
Contributor

@simonrussell simonrussell commented Jun 11, 2020

Related to #698.

The warning message can be disabled by setting exists_returns_integer to false. You will receive a single warning message when this is set.

@simonrussell
Copy link
Contributor Author

I'm not too sure what that broken test is relating to.

lib/redis.rb Outdated Show resolved Hide resolved
lib/redis.rb Outdated Show resolved Hide resolved
lib/redis.rb Outdated Show resolved Hide resolved
@byroot
Copy link
Collaborator

byroot commented Jun 11, 2020

Looks good. Please squash your commits together and I'll merge.

@byroot
Copy link
Collaborator

byroot commented Jun 11, 2020

I'm not too sure what that broken test is relating to.

Looks like rubocop is unhappy. Some lines are too long.

The warning message can be disabled by setting `exists_returns_integer`
to `false`.  You will receive a single warning message when this is set.
@simonrussell
Copy link
Contributor Author

Looks like rubocop is unhappy. Some lines are too long.

This was actually in relation to actual test failures in the pubsub ruby stuff, looked like duplicate things were in there.

But yes, seems that commit made Rubocop unhappy for other reasons. Normally I'd set up a local dev environment but I'm just relying on CI for this :)

@byroot
Copy link
Collaborator

byroot commented Jun 11, 2020

This was actually in relation to actual test failures in the pubsub ruby stuff

Unfortunately we have a couple flaky tests in the suite. It's getting better but it's really hard to stabilize, lot's of moving parts with the distributed redis testing.

@simonrussell
Copy link
Contributor Author

Right I thought it might be something like that. I think anything complex has some flaky tests somewhere...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants