fix: corruption of client during interrupt

redis · Sep 11, 2020 · 61c36e0 · 61c36e0
1 parent af087c5
commit 61c36e0
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 11 deletions.
diff --git a/lib/redis.rb b/lib/redis.rb
@@ -2438,14 +2438,13 @@ def unwatch
   end
 
   def pipelined
-    synchronize do |_client|
+    synchronize do |prior_client|
       begin
-        pipeline = Pipeline.new(@client)
-        original, @client = @client, pipeline
+        @client = Pipeline.new(prior_client)
         yield(self)
-        original.call_pipeline(@client)
+        prior_client.call_pipeline(@client)
       ensure
-        @client = original
+        @client = prior_client
       end
     end
   end
@@ -2481,17 +2480,16 @@ def pipelined
   # @see #watch
   # @see #unwatch
   def multi
-    synchronize do |client|
+    synchronize do |prior_client|
       if !block_given?
-        client.call([:multi])
+        prior_client.call([:multi])
       else
         begin
-          pipeline = Pipeline::Multi.new(@client)
-          original, @client = @client, pipeline
+          @client = Pipeline::Multi.new(prior_client)
           yield(self)
-          original.call_pipeline(pipeline)
+          prior_client.call_pipeline(@client)
         ensure
-          @client = original
+          @client = prior_client
         end
       end
     end

diff --git a/test/pipelining_commands_test.rb b/test/pipelining_commands_test.rb
@@ -252,4 +252,11 @@ def test_nested_pipeline_select_client_db
 
     assert_equal 3, r._client.db
   end
+
+  def test_pipeline_interrupt_preserves_client
+    original = r._client
+    Redis::Pipeline.stubs(:new).raises(Interrupt)
+    assert_raises(Interrupt) { r.pipelined {} }
+    assert_equal r._client, original
+  end
 end
diff --git a/test/transactions_test.rb b/test/transactions_test.rb
@@ -196,6 +196,13 @@ def test_multi_with_a_block_yielding_the_client
     assert_equal "s1", r.get("foo")
   end
 
+  def test_multi_with_interrupt_preserves_client
+    original = r._client
+    Redis::Pipeline.stubs(:new).raises(Interrupt)
+    assert_raises(Interrupt) { r.multi {} }
+    assert_equal r._client, original
+  end
+
   def test_raise_command_error_when_exec_fails
     redis_mock(exec: ->(*_) { "-ERROR" }) do |redis|
       assert_raises(Redis::CommandError) do