Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Update docker image for subpackages #2749

Closed

Conversation

BhavdeepSethi
Copy link

@BhavdeepSethi BhavdeepSethi commented May 4, 2024

Description

  • Current docker images used in tests have been deprecated
  • Recommended docker images to be used are redis-stack
  • To keep the test-suite up to date, changing the docker image and using the latest image to run the tests
  • Not updating redisgraph (eol) and search (breaking features)

Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
    • Existing tests pass for both old and new docker versions
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@BhavdeepSethi BhavdeepSethi force-pushed the bhavdeep/updateTests branch 2 times, most recently from 21e3bfb to d3e882c Compare May 4, 2024 23:41
@BhavdeepSethi BhavdeepSethi marked this pull request as ready for review May 4, 2024 23:42
@BhavdeepSethi BhavdeepSethi marked this pull request as draft May 5, 2024 00:41
@BhavdeepSethi BhavdeepSethi marked this pull request as ready for review May 5, 2024 00:41
@BhavdeepSethi
Copy link
Author

Looks like this will work with v5 branch too. Just minor formatting changes.

@BhavdeepSethi BhavdeepSethi deleted the bhavdeep/updateTests branch May 5, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants