Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-2553 - Adds code examples for the set tutorial #2582

Open
wants to merge 2 commits into
base: emb-examples
Choose a base branch
from

Conversation

justincastilla
Copy link

@justincastilla justincastilla commented Jul 25, 2023

Description

Adds code examples for the Set tutorial

DOC-2553

https://redislabs.atlassian.net/browse/DOC-2295

Adds example code for Set datatype as per DOC-2295


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

@justincastilla justincastilla changed the title Adds code examples for the set tutorial DOC-2553 - Adds code examples for the set tutorial Jul 25, 2023
await client.del('bikes:racing:usa')
// REMOVE_END

// STEP_START sAdd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, case matters for step names.

Suggested change
// STEP_START sAdd
// STEP_START sadd

assert.equal(res4, 2)
// REMOVE_END

// STEP_START sIsMember

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// STEP_START sIsMember
// STEP_START sismember

assert.equal(res6, false)
// REMOVE_END

// STEP_START sinster

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// STEP_START sinster
// STEP_START sinter

assert.deepEqual(res7, [ 'bike:1' ])
// REMOVE_END

// STEP_START sCard

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// STEP_START sCard
// STEP_START scard

await client.del('bikes:racing:france')
// REMOVE_END

// STEP_START sAdd_sMembers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// STEP_START sAdd_sMembers
// STEP_START sadd_smembers

assert.deepEqual(res10.sort(), ['bike:1', 'bike:2', 'bike:3'])
// REMOVE_END

// STEP_START smIsMember

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// STEP_START smIsMember
// STEP_START smismember

assert.deepEqual(res12, [true, true, false])
// REMOVE_END

// STEP_START sDiff

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// STEP_START sDiff
// STEP_START sdiff

await client.del('bikes:racing:italy')
// REMOVE_END

// STEP_START sRem

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// STEP_START sRem
// STEP_START srem

Copy link

@dwdougherty dwdougherty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added corrections to step case in multiple places. Please commit these changes. Otherwise, the docs build correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants