Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds testable examples for redis.io docs #2558

Closed
wants to merge 6 commits into from
Closed

Conversation

elena-kolevska
Copy link

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

itamarhaber and others added 5 commits January 22, 2023 21:18
- Add set & get example
- Use bash script to test doc tests
- Add package.json to doctests
- Add search-quickstart
* [DOC-2373] adds js samples to match search-quickstart md

* Fixes step matching for the Search quickstart

* Update search-quickstart.js

---------

Co-authored-by: Justin Castilla <pxlperfection@gmail.com>
Co-authored-by: Elena Kolevska <elena@kolevska.com>
Co-authored-by: Leibale Eidelman <me@leibale.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2023

Codecov Report

Patch coverage: 70.89% and project coverage change: -3.91 ⚠️

Comparison is base (abf2b4b) 95.85% compared to head (68e4494) 91.95%.

❗ Current head 68e4494 differs from pull request most recent head d268364. Consider uploading reports for the commit d268364 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2558      +/-   ##
==========================================
- Coverage   95.85%   91.95%   -3.91%     
==========================================
  Files         451      456       +5     
  Lines        4247     4561     +314     
  Branches      475      524      +49     
==========================================
+ Hits         4071     4194     +123     
- Misses        106      303     +197     
+ Partials       70       64       -6     
Impacted Files Coverage Δ
packages/client/lib/cluster/multi-command.ts 66.66% <ø> (+1.04%) ⬆️
packages/client/lib/commander.ts 79.54% <ø> (-15.91%) ⬇️
packages/client/lib/commands/CLUSTER_SLOTS.ts 100.00% <ø> (ø)
packages/client/lib/commands/XINFO_CONSUMERS.ts 100.00% <ø> (ø)
...ckages/client/lib/commands/generic-transformers.ts 94.17% <ø> (-5.83%) ⬇️
packages/client/lib/multi-command.ts 80.00% <ø> (-1.82%) ⬇️
...ckages/client/lib/commands/PUBSUB_SHARDCHANNELS.ts 40.00% <40.00%> (ø)
packages/client/lib/client/RESP2/decoder.ts 98.29% <60.00%> (-1.71%) ⬇️
packages/client/lib/client/commands-queue.ts 74.73% <60.97%> (-8.16%) ⬇️
packages/client/lib/cluster/index.ts 72.38% <62.26%> (-5.24%) ⬇️
... and 17 more

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* DOC-2526 Add code examples for the List tutorial

* adds formatting

---------

Co-authored-by: Justin Castilla <pxlperfection@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants