Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT.CREATE - set FIRST_KEY_INDEX to 1 #2440

Merged
merged 1 commit into from Mar 14, 2023

Conversation

carlhopf
Copy link
Contributor

Description

for cluster mode: set FIRST_KEY_INDEX to 1 (index name) for the FT.CREATE command


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

Copy link
Collaborator

@leibale leibale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ca1d04f) 95.60% compared to head (405e1d9) 95.60%.

❗ Current head 405e1d9 differs from pull request most recent head bab512c. Consider uploading reports for the commit bab512c to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2440   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         455      455           
  Lines        4548     4548           
  Branches      520      520           
=======================================
  Hits         4348     4348           
  Misses        129      129           
  Partials       71       71           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leibale leibale changed the title FT.CREATE, set FIRST_KEY_INDEX = 1 FT.CREATE - set FIRST_KEY_INDEX to 1 Mar 14, 2023
@leibale leibale merged commit 1d8302c into redis:master Mar 14, 2023
@leibale
Copy link
Collaborator

leibale commented Mar 17, 2023

@carlhopf actually this is incorrect, RediSearch indexes should be created in all nodes. Reverting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants