Handle unhandled errors in socket.reconnectStrategry
#2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edis into reconnect-strategy-errors
|
Hi @leibale , thanks for the fix. Do you have any plan to release it recently? as our new product is facing this issue with the latest |
|
Hi @just4fun, I'm planning to release it this week. |
|
This pull request introduces 1 alert when merging 52f0fb5 into 1fdee05 - view on LGTM.com new alerts:
|
leibale
added a commit
to leibale/node-redis
that referenced
this pull request
Aug 22, 2022
* handle errors in reconnect strategy * add test * fix retries typo * fix redis#2237 - flush queues on reconnect strategy error * Update socket.ts * Update socket.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2205 #2032
close #2234
fix #2237