Introduce EndpointConfig and load endpoint settings from the endpoints.json file #3836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uglide
force-pushed
the
tests_add_support_for_endpoints_config
branch
from
123c696
to
d937cd6
Compare
uglide
changed the title
|
Integration fails due to a new, unrelated problem with GearsTest.testFunctionListNoCodeVerboseZero test on the main branch. |
gerzse
previously approved these changes
May 17, 2024
sazzad16
requested changes
May 19, 2024
src/test/java/redis/clients/jedis/commands/jedis/MigrateTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/misc/AutomaticFailoverTest.java
Outdated
Show resolved
Hide resolved
- Introduce EndpointURIBuilder for creating customized URIs - Remove getJedis and getConnection methods - Improve naming for endpoint variables
- Add support for endpoints without username - Improve endpoints naming in AutomaticFailoverTest - Remove more hardcoded settings from Migrate tests - Fix comments in SSLACL tests
uglide
force-pushed
the
tests_add_support_for_endpoints_config
branch
from
99cfbdb
to
079172d
Compare
sazzad16
reviewed
May 21, 2024
src/test/java/redis/clients/jedis/misc/AutomaticFailoverTest.java
Outdated
Show resolved
Hide resolved
src/test/java/redis/clients/jedis/misc/AutomaticFailoverTest.java
Outdated
Show resolved
Hide resolved
atakavci
reviewed
May 21, 2024
sazzad16
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to introduce a better way to manage connection settings in the tests while making minimal possible impact.
Out of the scope:
Rewriting/Updating all the tests to support endpoint swapping