Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RediSearch DIALECT 5 #3831

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support RediSearch DIALECT 5 #3831

wants to merge 1 commit into from

Conversation

sazzad16
Copy link
Collaborator

@sazzad16 sazzad16 commented May 5, 2024

No description provided.

@sazzad16 sazzad16 requested review from uglide and a team May 5, 2024 13:05
uglide
uglide reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@uglide uglide left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there are a bunch of "redis.clients.jedis.exceptions.JedisDataException: DIALECT requires a non negative integer >=1 and <= 4". Do you plan to address them in this PR?

@sazzad16
Copy link
Collaborator Author

sazzad16 commented May 6, 2024

I see there are a bunch of "redis.clients.jedis.exceptions.JedisDataException: DIALECT requires a non negative integer >=1 and <= 4". Do you plan to address them in this PR?

@uglide These are coming from the server (RediSearch). Once the server is ready/updated, these should go away.
BTW, if you know any docker image where we can test dialect 5, let me know so we can test this PR with that.

@sazzad16 sazzad16 marked this pull request as draft May 6, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uglide uglide uglide left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sazzad16 @uglide