-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support automatic namespacing #3781
Open
sazzad16
wants to merge
12
commits into
redis:master
Choose a base branch
from
sazzad16:key-arg-prefix
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Mar 18, 2024
-
Proof-of-concept for automatic key prefixing
R-J Lim committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 7a806a1 - Browse repository at this point
Copy the full SHA 7a806a1View commit details -
Iteration on key-prefixing POC
- Demonstrated automatic key-prefixing for all subclasses of UnifiedJedis: JedisCluster, JedisPooled, and JedisSentineled - Key-prefixing is possible as long as the underlying CommandObjects can be customized. - CommandObjects cannot use commandArguments in its constructor since in the specific case of key-prefixing, commandArguments depends on the child constructor running first. So we lose caching of argument-less CommandObjects. - Based on this POC, the minimum changes required to jedis would be: - public constructors that allow UnifiedJedis and its subclasses to take a custom CommandObjects. - Consistent use of supplied CommandObjects throughout code (e.g. in Pipeline, Transaction, etc). - Removal of caching of argument-less CommandObjects in the constructor of CommandObjects. - Applications can then supply CommandObjects with custom behavior as necessary. Sample classes that implement the behavior of prefixed keys, etc are provided but these can be supplied by the application as long as required constructors are available.
R-J Lim committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 90a50b4 - Browse repository at this point
Copy the full SHA 90a50b4View commit details -
Second iteration on key-prefixing POC
- Restore cached key-less commands in CommandObjects - Support Transactions - New constructors do not take CommandExecutor - Requested JavaDoc regarding new constructors specifying RedisProtocol - New classes moved into 'prefix' packages - De-duplicate prefixing code
R-J Lim committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 7098377 - Browse repository at this point
Copy the full SHA 7098377View commit details -
- Restore public Transaction constructor that was removed - Use Connection.executeCommand instead of Connection.sendCommand
R-J Lim committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 02b8ba9 - Browse repository at this point
Copy the full SHA 02b8ba9View commit details -
Attempt to fix cluster cleanup before/after prefix test
R-J Lim committedMar 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 66f6336 - Browse repository at this point
Copy the full SHA 66f6336View commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d0be6bf - Browse repository at this point
Copy the full SHA d0be6bfView commit details
Commits on Mar 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dd4a735 - Browse repository at this point
Copy the full SHA dd4a735View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9770a9 - Browse repository at this point
Copy the full SHA d9770a9View commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for adf692e - Browse repository at this point
Copy the full SHA adf692eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b58462c - Browse repository at this point
Copy the full SHA b58462cView commit details
Commits on Apr 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4bb8198 - Browse repository at this point
Copy the full SHA 4bb8198View commit details
Commits on Apr 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9a86cce - Browse repository at this point
Copy the full SHA 9a86cceView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.